github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-12 02:24:21 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

[PR #4535] [MERGED] An inactive user shouldn't be able to be added as a collaborator #17416

New Issue
Closed
opened 2025-11-02 13:16:09 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-02 13:16:09 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/4535
Author: @adelowo
Created: 7/28/2018
Status: ✅ Merged
Merged: 8/7/2018
Merged by: @lafriks

Base: master ← Head: an_inactive_user_cannot_be_a_collaborator

📝 Commits (10+)

  • cbf4c92 an inactive user shouldn't be able to be a collaborator
  • bf402c7 use translated error message
  • 9d6f15c add active user check when adding a new collaborator via the api
  • ace2e37 fix translation text
  • 47278ad added collaborator test
  • 7decd51 improvee testcases
  • f850462 Merge branch 'master' into an_inactive_user_cannot_be_a_collaborator
  • 0d4d138 Merge branch 'master' of https://github.com/go-gitea/gitea into an_inactive_user_cannot_be_a_collaborator
  • 6f7007b Merge branch 'an_inactive_user_cannot_be_a_collaborator' of github.com:adelowo/gitea into an_inactive_user_cannot_be_a_collaborator
  • 931db1d Merge branch 'master' into an_inactive_user_cannot_be_a_collaborator

📊 Changes

4 files changed (+39 additions, -1 deletions)

View changed files

📝 options/locale/locale_en-US.ini (+2 -1)
📝 routers/api/v1/repo/collaborators.go (+7 -0)
📝 routers/repo/setting.go (+6 -0)
📝 routers/repo/settings_test.go (+24 -0)

📄 Description

Fixes #4534

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/4535 **Author:** [@adelowo](https://github.com/adelowo) **Created:** 7/28/2018 **Status:** ✅ Merged **Merged:** 8/7/2018 **Merged by:** [@lafriks](https://github.com/lafriks) **Base:** `master` ← **Head:** `an_inactive_user_cannot_be_a_collaborator` --- ### 📝 Commits (10+) - [`cbf4c92`](https://github.com/go-gitea/gitea/commit/cbf4c9275509e483c8c40c4a3eddaec43fc4f8a4) an inactive user shouldn't be able to be a collaborator - [`bf402c7`](https://github.com/go-gitea/gitea/commit/bf402c710675d1202d0944813105e7918cb49301) use translated error message - [`9d6f15c`](https://github.com/go-gitea/gitea/commit/9d6f15c81554f1446ece7b265726cc02256cdb1e) add active user check when adding a new collaborator via the api - [`ace2e37`](https://github.com/go-gitea/gitea/commit/ace2e37c9a555f061a7810e80dfe7d937c456802) fix translation text - [`47278ad`](https://github.com/go-gitea/gitea/commit/47278adb2338b0f57c6181e62166fcb29d795c1a) added collaborator test - [`7decd51`](https://github.com/go-gitea/gitea/commit/7decd5101f924bcb585f5b91a4b46f2c2b1c8bb3) improvee testcases - [`f850462`](https://github.com/go-gitea/gitea/commit/f85046206b5a821a03227496f5103f1fd27e9025) Merge branch 'master' into an_inactive_user_cannot_be_a_collaborator - [`0d4d138`](https://github.com/go-gitea/gitea/commit/0d4d13897c33633c536a9d54a35eea7df37b5acc) Merge branch 'master' of https://github.com/go-gitea/gitea into an_inactive_user_cannot_be_a_collaborator - [`6f7007b`](https://github.com/go-gitea/gitea/commit/6f7007b85a9530a5d046702dcc8fa3c3d0ab6b74) Merge branch 'an_inactive_user_cannot_be_a_collaborator' of github.com:adelowo/gitea into an_inactive_user_cannot_be_a_collaborator - [`931db1d`](https://github.com/go-gitea/gitea/commit/931db1d469165262a46f3861a9214e76ec340609) Merge branch 'master' into an_inactive_user_cannot_be_a_collaborator ### 📊 Changes **4 files changed** (+39 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `options/locale/locale_en-US.ini` (+2 -1) 📝 `routers/api/v1/repo/collaborators.go` (+7 -0) 📝 `routers/repo/setting.go` (+6 -0) 📝 `routers/repo/settings_test.go` (+24 -0) </details> ### 📄 Description Fixes #4534 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-02 13:16:10 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#17416
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?