[PR #4459] [CLOSED] Fix column droping for MySQL that need a new session for the new transaction #17381

New Issue

GiteaMirror · 2025-11-02T13:02:43-06:00

GiteaMirror commented

2025-11-02 13:02:43 -06:00

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/4459
Author: @back2root
Created: 7/17/2018
Status: ❌ Closed

Base: master ← Head: fix/mysql_dropping_columns

📝 Commits (1)

a4a7dd0 Fix column droping for MySQL that need a new session for the new transaction.

📊 Changes

2 files changed (+10 additions, -0 deletions)

View changed files

📝 models/migrations/v64.go (+5 -0)
📝 models/migrations/v69.go (+5 -0)

📄 Description

Finally Fixes #4360

Through PR #4440 an issue within migration scripts was introduced if running gitea with MySQL as Database.
This PR completely closes the database session and reopenes a new one to circumvent this issue. There may be a more performant solution. However, as this is only done once this solution should be sufficient.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/4459 **Author:** [@back2root](https://github.com/back2root) **Created:** 7/17/2018 **Status:** ❌ Closed **Base:** `master` ← **Head:** `fix/mysql_dropping_columns` --- ### 📝 Commits (1) - [`a4a7dd0`](https://github.com/go-gitea/gitea/commit/a4a7dd066041cf3a047b39c6bf375720d36e3293) Fix column droping for MySQL that need a new session for the new transaction. ### 📊 Changes **2 files changed** (+10 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `models/migrations/v64.go` (+5 -0) 📝 `models/migrations/v69.go` (+5 -0) </details> ### 📄 Description Finally Fixes #4360 Through PR #4440 an issue within migration scripts was introduced if running gitea with MySQL as Database. This PR completely closes the database session and reopenes a new one to circumvent this issue. There may be a more performant solution. However, as this is only done once this solution should be sufficient. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-02 13:02:47 -06:00

GiteaMirror closed this issue

2025-11-02 13:02:59 -06:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#17381