github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-12 02:24:21 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

[PR #4312] [MERGED] Fix open redirect vulnerability on login screen #17327

New Issue
Closed
opened 2025-11-02 12:32:40 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-02 12:32:40 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/4312
Author: @jonasfranz
Created: 6/25/2018
Status: ✅ Merged
Merged: 6/26/2018
Merged by: @lunny

Base: master ← Head: fix-open-redirect

📝 Commits (4)

  • b49ee5d Fix open redirect vulnerability on login screen
  • 3d722b7 Reorder imports
  • fff3256 Replace www. from Domain too
  • 3913603 Merge branch 'master' into fix-open-redirect

📊 Changes

3 files changed (+50 additions, -1 deletions)

View changed files

📝 modules/util/util.go (+13 -0)
📝 modules/util/util_test.go (+35 -0)
📝 routers/user/auth.go (+2 -1)

📄 Description

Fix #4307 by checking if URL is external before redirecting.

Affected:

  • 2FA
  • U2F
  • Normal login

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/4312 **Author:** [@jonasfranz](https://github.com/jonasfranz) **Created:** 6/25/2018 **Status:** ✅ Merged **Merged:** 6/26/2018 **Merged by:** [@lunny](https://github.com/lunny) **Base:** `master` ← **Head:** `fix-open-redirect` --- ### 📝 Commits (4) - [`b49ee5d`](https://github.com/go-gitea/gitea/commit/b49ee5d4dab1299222bc683a6d5873d8b0e41529) Fix open redirect vulnerability on login screen - [`3d722b7`](https://github.com/go-gitea/gitea/commit/3d722b7edce914036691434e11007d879cfcd0f8) Reorder imports - [`fff3256`](https://github.com/go-gitea/gitea/commit/fff3256339a4f0ca3ab9a7ad8c2aa960412558b5) Replace www. from Domain too - [`3913603`](https://github.com/go-gitea/gitea/commit/39136034bfb2b72f9c11278cab4e12ca5c9d7e44) Merge branch 'master' into fix-open-redirect ### 📊 Changes **3 files changed** (+50 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `modules/util/util.go` (+13 -0) 📝 `modules/util/util_test.go` (+35 -0) 📝 `routers/user/auth.go` (+2 -1) </details> ### 📄 Description Fix #4307 by checking if URL is external before redirecting. Affected: * 2FA * U2F * Normal login --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-02 12:32:40 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#17327
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?