ldap: an error is logged when a user is not an admin #1732

New Issue

2025-11-02T04:11:36-06:00

GiteaMirror commented

2025-11-02 04:11:36 -06:00

Originally created by @junkb on GitHub (Apr 26, 2018).

Gitea version (or commit ref): 1.4.0
Git version: n/a
Operating system: ubuntu 17.10
Database (use [x]):
- PostgreSQL
- MySQL
- MSSQL
- SQLite
Can you reproduce the bug at https://try.gitea.io:
- Yes (provide example URL)
- No
- Not relevant
Log gist: https://gist.github.com/junkb/b5abbf7ec4ee1f975a6a423b87c51d37

Description

when the ldap search is performed to determine if a user is an admin, if there is no result [meaning the user in question is not an admin], an error is logged. this is a little misleading - if there is no result, because the user is not in the admin group, then things are working exactly as they should, and there is no error. i think it would be helpful if this outcome were handled and logged differently than an error

Originally created by @junkb on GitHub (Apr 26, 2018).  - Gitea version (or commit ref): 1.4.0 - Git version: n/a - Operating system: ubuntu 17.10 - Database (use `[x]`): - [ ] PostgreSQL - [x] MySQL - [ ] MSSQL - [ ] SQLite - Can you reproduce the bug at https://try.gitea.io: - [ ] Yes (provide example URL) - [ ] No - [x] Not relevant - Log gist: https://gist.github.com/junkb/b5abbf7ec4ee1f975a6a423b87c51d37 ## Description when the ldap search is performed to determine if a user is an admin, if there is no result [meaning the user in question is not an admin], an error is logged. this is a little misleading - if there is no result, because the user is not in the admin group, then things are working exactly as they should, and there is no error. i think it would be helpful if this outcome were handled and logged differently than an error

GiteaMirror added the type/bug label 2025-11-02 04:11:36 -06:00

GiteaMirror closed this issue

2025-11-02 04:11:36 -06:00

GiteaMirror referenced this issue

2025-11-02 12:00:26 -06:00

[PR #1732] [MERGED] feat: upgrade drone docker image to support multi-stage build. #16020

Sign in to join this conversation.