[PR #4251] [MERGED] Fix #4060 by showing second line of commit #17301

Closed
opened 2025-11-02 12:32:04 -06:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/4251
Author: @jonasfranz
Created: 6/15/2018
Status: Merged
Merged: 6/15/2018
Merged by: @techknowlogick

Base: masterHead: fix-multiline


📝 Commits (2)

  • 14f243f Show second line by using >= 1 instead of > 1
  • 2a136f9 Merge branch 'master' into fix-multiline

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 modules/templates/helper.go (+1 -1)

📄 Description

Fix #4060

strings.TrimSpace actually removes the \n at the end of the commit message. Because of that the comparison must be changed.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/4251 **Author:** [@jonasfranz](https://github.com/jonasfranz) **Created:** 6/15/2018 **Status:** ✅ Merged **Merged:** 6/15/2018 **Merged by:** [@techknowlogick](https://github.com/techknowlogick) **Base:** `master` ← **Head:** `fix-multiline` --- ### 📝 Commits (2) - [`14f243f`](https://github.com/go-gitea/gitea/commit/14f243fc43928ae51ade012d1a62df47ccb08a93) Show second line by using >= 1 instead of > 1 - [`2a136f9`](https://github.com/go-gitea/gitea/commit/2a136f9f0e85c3adf2874e3b9c9ae0f12d432a24) Merge branch 'master' into fix-multiline ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `modules/templates/helper.go` (+1 -1) </details> ### 📄 Description Fix #4060 `strings.TrimSpace` actually removes the `\n` at the end of the commit message. Because of that the comparison must be changed. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-02 12:32:04 -06:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#17301