[PR #4220] [MERGED] Fix swagger errors #17289

New Issue

GiteaMirror · 2025-11-02T12:31:47-06:00

GiteaMirror commented

2025-11-02 12:31:47 -06:00

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/4220
Author: @sapk
Created: 6/11/2018
Status: ✅ Merged
Merged: 6/12/2018
Merged by: @appleboy

Base: master ← Head: fix-swagger-errors

📝 Commits (10+)

81b841f Fix raw parameters
000e96a Generate swagger json
bc159ca Add missing in: body
6884605 Add missing in: body
c34cd5e Fix typo: duplicate name
43f5249 Fix typo: duplicate operationId
0fdc6d3 Fix typos
792f9a4 Fix typos
b8db734 Add some missing hook parameters
8da4eca Add missing tokens parameters

📊 Changes

15 files changed (+432 additions, -254 deletions)

View changed files

📝 .drone.yml (+1 -0)
📝 public/swagger.v1.json (+273 -203)
📝 routers/api/v1/misc/markdown.go (+6 -3)
📝 routers/api/v1/org/hook.go (+49 -0)
📝 routers/api/v1/org/team.go (+3 -3)
📝 routers/api/v1/repo/file.go (+1 -1)
📝 routers/api/v1/repo/hook.go (+6 -1)
📝 routers/api/v1/repo/issue_comment.go (+2 -2)
📝 routers/api/v1/repo/issue_tracked_time.go (+4 -4)
📝 routers/api/v1/repo/milestone.go (+24 -19)
📝 routers/api/v1/repo/repo.go (+6 -6)
📝 routers/api/v1/swagger/options.go (+42 -10)
📝 routers/api/v1/swagger/repo.go (+1 -0)
📝 routers/api/v1/user/app.go (+12 -0)
📝 routers/api/v1/user/follower.go (+2 -2)

📄 Description

Fix all the resting errors to have a valid swagger file.

They are still some warnings but nothing blocking.

Doing so I found that some request still misses son parameters for some POST/PUT/PATCH request. This means the a client generated from the swagger file will not work completely.

Fix #4088 by activating validation in drone
Should fix #4010.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/4220 **Author:** [@sapk](https://github.com/sapk) **Created:** 6/11/2018 **Status:** ✅ Merged **Merged:** 6/12/2018 **Merged by:** [@appleboy](https://github.com/appleboy) **Base:** `master` ← **Head:** `fix-swagger-errors` --- ### 📝 Commits (10+) - [`81b841f`](https://github.com/go-gitea/gitea/commit/81b841f19d92820532f3583c0f904ae66b59ccc3) Fix raw parameters - [`000e96a`](https://github.com/go-gitea/gitea/commit/000e96a2ca0c24ef1f93026cdba56d0f2e4bf062) Generate swagger json - [`bc159ca`](https://github.com/go-gitea/gitea/commit/bc159ca815924719a34ea54dd9f0478129047e63) Add missing in: body - [`6884605`](https://github.com/go-gitea/gitea/commit/68846057d12456ed9bff160715425ca0a5e31cac) Add missing in: body - [`c34cd5e`](https://github.com/go-gitea/gitea/commit/c34cd5ebc216b62f95caca616cab11292200d8a8) Fix typo: duplicate name - [`43f5249`](https://github.com/go-gitea/gitea/commit/43f52497e85f2b3e67849e0375734115e1547d41) Fix typo: duplicate operationId - [`0fdc6d3`](https://github.com/go-gitea/gitea/commit/0fdc6d3d337b153683c68064514041586e2fab29) Fix typos - [`792f9a4`](https://github.com/go-gitea/gitea/commit/792f9a4dad66f869626d1cbbee376507b09d7104) Fix typos - [`b8db734`](https://github.com/go-gitea/gitea/commit/b8db734b8b60a69b76142de791ef530961a5eeaf) Add some missing hook parameters - [`8da4eca`](https://github.com/go-gitea/gitea/commit/8da4eca462e5e23078582c47cd1cb59a26d49d70) Add missing tokens parameters ### 📊 Changes **15 files changed** (+432 additions, -254 deletions) <details> <summary>View changed files</summary> 📝 `.drone.yml` (+1 -0) 📝 `public/swagger.v1.json` (+273 -203) 📝 `routers/api/v1/misc/markdown.go` (+6 -3) 📝 `routers/api/v1/org/hook.go` (+49 -0) 📝 `routers/api/v1/org/team.go` (+3 -3) 📝 `routers/api/v1/repo/file.go` (+1 -1) 📝 `routers/api/v1/repo/hook.go` (+6 -1) 📝 `routers/api/v1/repo/issue_comment.go` (+2 -2) 📝 `routers/api/v1/repo/issue_tracked_time.go` (+4 -4) 📝 `routers/api/v1/repo/milestone.go` (+24 -19) 📝 `routers/api/v1/repo/repo.go` (+6 -6) 📝 `routers/api/v1/swagger/options.go` (+42 -10) 📝 `routers/api/v1/swagger/repo.go` (+1 -0) 📝 `routers/api/v1/user/app.go` (+12 -0) 📝 `routers/api/v1/user/follower.go` (+2 -2) </details> ### 📄 Description Fix all the resting errors to have a valid swagger file. They are still some warnings but nothing blocking. Doing so I found that some request still misses son parameters for some POST/PUT/PATCH request. This means the a client generated from the swagger file will not work completely. Fix #4088 by activating validation in drone Should fix #4010. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-02 12:31:47 -06:00

GiteaMirror closed this issue

2025-11-02 12:31:47 -06:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#17289