github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-05-23 15:57:22 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

Markdown parsing incorrectly for video links #1728

New Issue
Closed
opened 2025-11-02 04:11:30 -06:00 by GiteaMirror · 3 comments
GiteaMirror commented 2025-11-02 04:11:30 -06:00
Owner
Copy Link

Originally created by @coolaj86 on GitHub (Apr 23, 2018).

Gitea version 1.4.0

Go version 1.1.0

This snippet in the README.md should create an image that links to the YouTube video:

[![Free SSL with Greenlock.js](https://i.imgur.com/Y8ix6Ts.png)](https://youtu.be/e8vaR4CEZ5s)

Like this:

Free SSL with Greenlock.js

Instead it creates an <a> tag with an empty string that cannot be clicked on for the YouTube video and a second link to the picture, which links to the picture itself.

Example:

dfabdd15dd/README.md

Originally created by @coolaj86 on GitHub (Apr 23, 2018). Gitea version 1.4.0 Go version 1.1.0 This snippet in the README.md should create an image that links to the YouTube video: ``` [![Free SSL with Greenlock.js](https://i.imgur.com/Y8ix6Ts.png)](https://youtu.be/e8vaR4CEZ5s) ``` Like this: [![Free SSL with Greenlock.js](https://i.imgur.com/Y8ix6Ts.png)](https://youtu.be/e8vaR4CEZ5s) Instead it creates an `<a>` tag with an empty string that cannot be clicked on for the YouTube video and a second link to the picture, which links to the picture itself. Example: https://git.coolaj86.com/coolaj86/greenlock-express.js/src/commit/dfabdd15dd04742a7af296b70ad84d674f956953/README.md
GiteaMirror added the type/bug label 2025-11-02 04:11:30 -06:00
GiteaMirror commented 2025-11-02 04:11:31 -06:00
Author
Owner
Copy Link

@coolaj86 commented on GitHub (Apr 23, 2018):

This commit on my own gitea instance demonstrates that the link is parsed incorrectly.

@coolaj86 commented on GitHub (Apr 23, 2018): [This commit](https://git.coolaj86.com/coolaj86/greenlock-express.js/src/commit/dfabdd15dd04742a7af296b70ad84d674f956953/README.md) on my own gitea instance demonstrates that the link is parsed incorrectly.
GiteaMirror commented 2025-11-02 04:11:31 -06:00
Author
Owner
Copy Link

@laoshaw commented on GitHub (Nov 14, 2018):

Just found out this bug, it's impractical to embed any video without fixing this, as shown a pic for the video is very helpful.

@laoshaw commented on GitHub (Nov 14, 2018): Just found out this bug, it's impractical to embed any video without fixing this, as shown a pic for the video is very helpful.
GiteaMirror commented 2025-11-02 04:11:31 -06:00
Author
Owner
Copy Link

@laoshaw commented on GitHub (Dec 2, 2018):

@coolaj86 gitea 1.6.0 seems fixed this, I can click on the image then it jumps to youtube and starts playing.

still, if you self-host the video, you need click on the image to see the video, then click on the video to play it, it would be nice if I can play the video with one click though

@laoshaw commented on GitHub (Dec 2, 2018): @coolaj86 gitea 1.6.0 seems fixed this, I can click on the image then it jumps to youtube and starts playing. still, if you self-host the video, you need click on the image to see the video, then click on the video to play it, it would be nice if I can play the video with one click though
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label type/bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#1728
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?