[PR #3988] [MERGED] Re-enable random avatar feature #17183

New Issue

GiteaMirror · 2025-11-02T12:28:41-06:00

GiteaMirror commented

2025-11-02 12:28:41 -06:00

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/3988
Author: @daviian
Created: 5/18/2018
Status: ✅ Merged
Merged: 5/19/2018
Merged by: @lunny

Base: master ← Head: bugfix/reenable-random-avatar

📝 Commits (3)

b11be8c reenable random avatar feature
12dfea0 replace Size check by Filename check
073cbcf Merge branch 'master' into bugfix/reenable-random-avatar

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 routers/user/setting/profile.go (+1 -1)

📄 Description

PR fixes not usable random avatars because a check introduced to enable custom avatars made the code responsible for random avatars unreachable.

This behaviour was and is still noticeable in gogs as well.

Furthermore with this change the radio buttons in the avatar form are useable again.
But IMHO the avatar form should be refurbished to better communicate the available features and how to achieve them.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/3988 **Author:** [@daviian](https://github.com/daviian) **Created:** 5/18/2018 **Status:** ✅ Merged **Merged:** 5/19/2018 **Merged by:** [@lunny](https://github.com/lunny) **Base:** `master` ← **Head:** `bugfix/reenable-random-avatar` --- ### 📝 Commits (3) - [`b11be8c`](https://github.com/go-gitea/gitea/commit/b11be8c53a6504937620170461e6712702859a77) reenable random avatar feature - [`12dfea0`](https://github.com/go-gitea/gitea/commit/12dfea01d0ef2b813e92f12b52f6e11b1dbfc993) replace Size check by Filename check - [`073cbcf`](https://github.com/go-gitea/gitea/commit/073cbcf73981bef055b8c4c756343cf4c53741d1) Merge branch 'master' into bugfix/reenable-random-avatar ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `routers/user/setting/profile.go` (+1 -1) </details> ### 📄 Description PR fixes not usable random avatars because a check introduced to enable custom avatars made the code responsible for random avatars unreachable. This behaviour was and is still noticeable in gogs as well. Furthermore with this change the radio buttons in the avatar form are useable again. But IMHO the avatar form should be refurbished to better communicate the available features and how to achieve them. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-02 12:28:41 -06:00

GiteaMirror closed this issue

2025-11-02 12:28:41 -06:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#17183