[PR #3983] [CLOSED] make avatar radio buttons read-only #17181

New Issue

GiteaMirror · 2025-11-02T12:28:37-06:00

GiteaMirror commented

2025-11-02 12:28:37 -06:00

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/3983
Author: @daviian
Created: 5/17/2018
Status: ❌ Closed

Base: master ← Head: enhancement/read-only-radio-buttons

📝 Commits (1)

69dbf77 make avatar radio buttons read-only

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 templates/user/settings/profile.tmpl (+2 -2)

📄 Description

This PR makes the radio buttons for the profile avatar setting read only as they are useless anyway and confuse the user (me included).

To upload an avatar image you just have to provide an image in the file input and submit. Radio button changes on it's own.
But now it gets confusing. If I want to undo that change to use my gravatar image again I am dempted to click on the radio button to look up an image by my email and click "Update Avatar".
However this doesn't work as expected. Instead a user has to click "Delete Avatar".

To prevent that misunderstanding the radio buttons should be read-only.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/3983 **Author:** [@daviian](https://github.com/daviian) **Created:** 5/17/2018 **Status:** ❌ Closed **Base:** `master` ← **Head:** `enhancement/read-only-radio-buttons` --- ### 📝 Commits (1) - [`69dbf77`](https://github.com/go-gitea/gitea/commit/69dbf7731a1453e27f925d6cc5e3af17ef461e2e) make avatar radio buttons read-only ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `templates/user/settings/profile.tmpl` (+2 -2) </details> ### 📄 Description This PR makes the radio buttons for the profile avatar setting read only as they are useless anyway and confuse the user (me included). To upload an avatar image you just have to provide an image in the file input and submit. Radio button changes on it's own. But now it gets confusing. If I want to undo that change to use my gravatar image again I am dempted to click on the radio button to look up an image by my email and click "Update Avatar". However this doesn't work as expected. Instead a user has to click "Delete Avatar". To prevent that misunderstanding the radio buttons should be read-only. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-02 12:28:38 -06:00

GiteaMirror closed this issue

2025-11-02 12:28:38 -06:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#17181