github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-15 20:52:52 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

[PR #3839] [MERGED] Support secure cookie for csrf-token #17106

New Issue
Closed
opened 2025-11-02 12:26:26 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-02 12:26:26 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/3839
Author: @AleksandrBulyshchenko
Created: 4/23/2018
Status: ✅ Merged
Merged: 5/21/2018
Merged by: @lafriks

Base: master ← Head: csrf-security

📝 Commits (2)

  • 828ac72 dep: Update github.com/go-macaron/csrf
  • c8d7625 routers: set csrf-token security depending on COOKIE_SECURE

📊 Changes

3 files changed (+21 additions, -8 deletions)

View changed files

📝 Gopkg.lock (+2 -1)
📝 routers/routes/routes.go (+1 -0)
📝 vendor/github.com/go-macaron/csrf/csrf.go (+18 -7)

📄 Description

Fixes #1734

Currently SetCookie for csrf has secure hardcodded to false.
This passes security argument to cookie creation and set it by COOKIE_SECURE config var.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/3839 **Author:** [@AleksandrBulyshchenko](https://github.com/AleksandrBulyshchenko) **Created:** 4/23/2018 **Status:** ✅ Merged **Merged:** 5/21/2018 **Merged by:** [@lafriks](https://github.com/lafriks) **Base:** `master` ← **Head:** `csrf-security` --- ### 📝 Commits (2) - [`828ac72`](https://github.com/go-gitea/gitea/commit/828ac721009f55de756685341982c9372c995781) dep: Update github.com/go-macaron/csrf - [`c8d7625`](https://github.com/go-gitea/gitea/commit/c8d76255eda4f81d27998f6ad6e194944baa612e) routers: set csrf-token security depending on COOKIE_SECURE ### 📊 Changes **3 files changed** (+21 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `Gopkg.lock` (+2 -1) 📝 `routers/routes/routes.go` (+1 -0) 📝 `vendor/github.com/go-macaron/csrf/csrf.go` (+18 -7) </details> ### 📄 Description Fixes #1734 Currently SetCookie for csrf has secure hardcodded to false. This passes security argument to cookie creation and set it by COOKIE_SECURE config var. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-02 12:26:26 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#17106
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?