[PR #3707] [MERGED] Don't warn users about *every* dirty form #17051

New Issue

GiteaMirror · 2025-11-02T12:25:09-06:00

GiteaMirror commented

2025-11-02 12:25:09 -06:00

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/3707
Author: @Treora
Created: 3/22/2018
Status: ✅ Merged
Merged: 3/23/2018
Merged by: @lunny

Base: master ← Head: fewer-form-warnings

📝 Commits (1)

1c3914f Don't warn users about every dirty form

📊 Changes

15 files changed (+19 additions, -16 deletions)

View changed files

📝 public/js/index.js (+5 -2)
📝 templates/admin/base/search.tmpl (+1 -1)
📝 templates/admin/config.tmpl (+1 -1)
📝 templates/explore/code.tmpl (+1 -1)
📝 templates/explore/search.tmpl (+1 -1)
📝 templates/org/settings/delete.tmpl (+1 -1)
📝 templates/repo/commits_table.tmpl (+1 -1)
📝 templates/repo/home.tmpl (+1 -1)
📝 templates/repo/issue/search.tmpl (+1 -1)
📝 templates/repo/search.tmpl (+1 -1)
📝 templates/user/auth/activate.tmpl (+1 -1)
📝 templates/user/auth/forgot_passwd.tmpl (+1 -1)
📝 templates/user/auth/reset_passwd.tmpl (+1 -1)
📝 templates/user/settings/applications.tmpl (+1 -1)
📝 templates/user/settings/delete.tmpl (+1 -1)

📄 Description

The choice regarding which forms should or should not trigger a warning
is subjective. I tried to be consistent and not warn about forms that:

run an action, rather than edit data: search, send an email.
delete data: a warning about losing data would be confusing

Note that forms on sign-in pages were already ignored (using a selector,
rather than an explicit class on the form element).

Fixes #3698.

Note: I did not yet manage to build gitea (due to some problem with golang), so I have not been able to test this change properly

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/3707 **Author:** [@Treora](https://github.com/Treora) **Created:** 3/22/2018 **Status:** ✅ Merged **Merged:** 3/23/2018 **Merged by:** [@lunny](https://github.com/lunny) **Base:** `master` ← **Head:** `fewer-form-warnings` --- ### 📝 Commits (1) - [`1c3914f`](https://github.com/go-gitea/gitea/commit/1c3914f5458ef7995174dcc86e404f67e3fae10d) Don't warn users about *every* dirty form ### 📊 Changes **15 files changed** (+19 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `public/js/index.js` (+5 -2) 📝 `templates/admin/base/search.tmpl` (+1 -1) 📝 `templates/admin/config.tmpl` (+1 -1) 📝 `templates/explore/code.tmpl` (+1 -1) 📝 `templates/explore/search.tmpl` (+1 -1) 📝 `templates/org/settings/delete.tmpl` (+1 -1) 📝 `templates/repo/commits_table.tmpl` (+1 -1) 📝 `templates/repo/home.tmpl` (+1 -1) 📝 `templates/repo/issue/search.tmpl` (+1 -1) 📝 `templates/repo/search.tmpl` (+1 -1) 📝 `templates/user/auth/activate.tmpl` (+1 -1) 📝 `templates/user/auth/forgot_passwd.tmpl` (+1 -1) 📝 `templates/user/auth/reset_passwd.tmpl` (+1 -1) 📝 `templates/user/settings/applications.tmpl` (+1 -1) 📝 `templates/user/settings/delete.tmpl` (+1 -1) </details> ### 📄 Description The choice regarding which forms should or should not trigger a warning is subjective. I tried to be consistent and not warn about forms that: - run an action, rather than edit data: search, send an email. - delete data: a warning about losing data would be confusing Note that forms on sign-in pages were already ignored (using a selector, rather than an explicit class on the form element). Fixes #3698. *Note: I did not yet manage to build gitea (due to some problem with golang), so I have not been able to test this change properly* --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-02 12:25:09 -06:00

GiteaMirror closed this issue

2025-11-02 12:25:09 -06:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#17051