[PR #3705] [MERGED] Multiple assignees #17050

Closed
opened 2025-11-02 12:25:07 -06:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/3705
Author: @kolaente
Created: 3/22/2018
Status: Merged
Merged: 5/9/2018
Merged by: @lafriks

Base: masterHead: multiple-assignees


📝 Commits (10+)

  • 1bd777b Issue assignees are now loaded of a seperate table when displayed in the UI
  • 3c0b4e1 Multiple assignees work so far, but current state is alpha
  • 3d69908 Various cleanups
  • 8720925 Made removing all assignees working again
  • edad903 Don't send the action attribute, its not used
  • 269f426 Made adding assignes via gui almost work
  • 6583569 fmt
  • a0bf332 Made adding assignees work when creating an issue
  • cf6d9d3 cleanup
  • df4dc8d When viewing issues or prs via the api, assignees are now shown correcctly

📊 Changes

36 files changed (+1012 additions, -451 deletions)

View changed files

📝 models/error.go (+16 -0)
📝 models/fixtures/issue.yml (+0 -2)
models/fixtures/issue_assignees.yml (+8 -0)
📝 models/fixtures/issue_user.yml (+0 -3)
📝 models/issue.go (+57 -102)
models/issue_assignees.go (+263 -0)
models/issue_assignees_test.go (+71 -0)
📝 models/issue_comment.go (+51 -61)
📝 models/issue_list.go (+23 -23)
📝 models/issue_mail.go (+10 -3)
📝 models/issue_user.go (+28 -24)
📝 models/issue_user_test.go (+0 -17)
📝 models/migrations/migrations.go (+4 -9)
📝 models/migrations/v56.go (+11 -1)
models/migrations/v64.go (+129 -0)
📝 models/models.go (+1 -0)
📝 models/pull.go (+6 -1)
📝 models/repo.go (+3 -3)
📝 models/user.go (+3 -3)
📝 models/webhook_dingtalk.go (+5 -1)

...and 16 more files

📄 Description

Blocked by go-gitea/go-sdk#99

This implements multiple assignees as of #1884. You can add and remove multiple assignees via the ui when creating issues or pull requests on the sidebar to the right as you do with labels.

I modified the api to reflect Github's API behavior while being backwards compatible.

Todo

  • Unit tests for new functions
  • Update go-sdk once it's merged

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/3705 **Author:** [@kolaente](https://github.com/kolaente) **Created:** 3/22/2018 **Status:** ✅ Merged **Merged:** 5/9/2018 **Merged by:** [@lafriks](https://github.com/lafriks) **Base:** `master` ← **Head:** `multiple-assignees` --- ### 📝 Commits (10+) - [`1bd777b`](https://github.com/go-gitea/gitea/commit/1bd777b5837bfe9b6a9bc1ce2079e867c22a3ba6) Issue assignees are now loaded of a seperate table when displayed in the UI - [`3c0b4e1`](https://github.com/go-gitea/gitea/commit/3c0b4e16b15e4edfb779826d2a774992ccd29ea1) Multiple assignees work so far, but current state is alpha - [`3d69908`](https://github.com/go-gitea/gitea/commit/3d69908762e47e9a8f249caa7db5d53ebd10fad9) Various cleanups - [`8720925`](https://github.com/go-gitea/gitea/commit/87209251df6c1de69a402b6df5a9f5a44546ab27) Made removing all assignees working again - [`edad903`](https://github.com/go-gitea/gitea/commit/edad903a15ac6e1369f2b93a271ec14ac3ada64f) Don't send the action attribute, its not used - [`269f426`](https://github.com/go-gitea/gitea/commit/269f426d450661d1e2c7bb9b6901e3549cf7a2e6) Made adding assignes via gui almost work - [`6583569`](https://github.com/go-gitea/gitea/commit/6583569dae63aeb76f0c7120527328ba9042fb05) fmt - [`a0bf332`](https://github.com/go-gitea/gitea/commit/a0bf332716c005680ca56ef7b3f51f84137587c3) Made adding assignees work when creating an issue - [`cf6d9d3`](https://github.com/go-gitea/gitea/commit/cf6d9d30205a0b2b6d14ac0135d4dd2eae2691d7) cleanup - [`df4dc8d`](https://github.com/go-gitea/gitea/commit/df4dc8d677b1e492a757d684cf7ff8e4d3dff975) When viewing issues or prs via the api, assignees are now shown correcctly ### 📊 Changes **36 files changed** (+1012 additions, -451 deletions) <details> <summary>View changed files</summary> 📝 `models/error.go` (+16 -0) 📝 `models/fixtures/issue.yml` (+0 -2) ➕ `models/fixtures/issue_assignees.yml` (+8 -0) 📝 `models/fixtures/issue_user.yml` (+0 -3) 📝 `models/issue.go` (+57 -102) ➕ `models/issue_assignees.go` (+263 -0) ➕ `models/issue_assignees_test.go` (+71 -0) 📝 `models/issue_comment.go` (+51 -61) 📝 `models/issue_list.go` (+23 -23) 📝 `models/issue_mail.go` (+10 -3) 📝 `models/issue_user.go` (+28 -24) 📝 `models/issue_user_test.go` (+0 -17) 📝 `models/migrations/migrations.go` (+4 -9) 📝 `models/migrations/v56.go` (+11 -1) ➕ `models/migrations/v64.go` (+129 -0) 📝 `models/models.go` (+1 -0) 📝 `models/pull.go` (+6 -1) 📝 `models/repo.go` (+3 -3) 📝 `models/user.go` (+3 -3) 📝 `models/webhook_dingtalk.go` (+5 -1) _...and 16 more files_ </details> ### 📄 Description ~Blocked by go-gitea/go-sdk#99~ This implements multiple assignees as of #1884. You can add and remove multiple assignees via the ui when creating issues or pull requests on the sidebar to the right as you do with labels. I modified the api to reflect [Github's API behavior](https://developer.github.com/v3/issues/#edit-an-issue) while being backwards compatible. #### Todo * [x] Unit tests for new functions * [x] Update `go-sdk` once it's merged --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-02 12:25:07 -06:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#17050