[PR #3699] [MERGED] add your_repositories to types #17049

New Issue

GiteaMirror · 2025-11-02T12:25:06-06:00

GiteaMirror commented

2025-11-02 12:25:06 -06:00

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/3699
Author: @alxwrd
Created: 3/20/2018
Status: ✅ Merged
Merged: 3/20/2018
Merged by: @lafriks

Base: master ← Head: issue-page-fix

📝 Commits (1)

f4f5e47 add your_repositories to types

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 routers/repo/issue.go (+1 -1)

📄 Description

hello!

This is to fix a small issue I noticed on the Issues and Pull Request dashboards.

When selecting "In your repositories", the selection doesn't get highlighted.

From the templates this seems to be based on the .viewType, however when type=your_repositories, .viewType is set to "all".

This means the css class isn't applied because the issues template contains:

<a class="{{if eq .ViewType "your_repositories"}}ui basic blue button{{end}} item" ...

issues.tmpl:8

In the below gif I have added the .viewType to the page:

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/3699 **Author:** [@alxwrd](https://github.com/alxwrd) **Created:** 3/20/2018 **Status:** ✅ Merged **Merged:** 3/20/2018 **Merged by:** [@lafriks](https://github.com/lafriks) **Base:** `master` ← **Head:** `issue-page-fix` --- ### 📝 Commits (1) - [`f4f5e47`](https://github.com/go-gitea/gitea/commit/f4f5e476af690f819f8de38fbf9bbe34cb99eb8d) add your_repositories to types ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `routers/repo/issue.go` (+1 -1) </details> ### 📄 Description hello! This is to fix a small issue I noticed on the Issues and Pull Request dashboards. When selecting "In your repositories", the selection doesn't get highlighted. From the templates this seems to be based on the `.viewType`, however when `type=your_repositories`, `.viewType` is set to "all". This means the css class isn't applied because the issues template contains: ```html <a class="{{if eq .ViewType "your_repositories"}}ui basic blue button{{end}} item" ... ``` [issues.tmpl:8](https://github.com/go-gitea/gitea/blob/master/templates/user/dashboard/issues.tmpl#L8) In the below gif I have added the `.viewType` to the page: ![no_highlight_your_repos](https://user-images.githubusercontent.com/13941027/37671649-18c84168-2c64-11e8-952f-dcff4037626f.gif) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-02 12:25:06 -06:00

GiteaMirror closed this issue

2025-11-02 12:25:06 -06:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#17049