[PR #3694] [MERGED] Change title to existing locale entry for protected branch settings #17047

Closed
opened 2025-11-02 12:25:03 -06:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/3694
Author: @Chri-s
Created: 3/19/2018
Status: Merged
Merged: 3/21/2018
Merged by: @lafriks

Base: masterHead: protected-branch-title-fix


📝 Commits (5)

  • 91098c4 Change title to existing locale entry
  • 2f56be0 Merge branch 'master' into protected-branch-title-fix
  • 6fbb039 Merge branch 'master' into protected-branch-title-fix
  • f596ed8 Merge branch 'master' into protected-branch-title-fix
  • 51c88d4 Merge branch 'master' into protected-branch-title-fix

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 routers/repo/setting_protected_branch.go (+1 -1)

📄 Description

The title of the settings page for a protected branch references an invalid entry in the locale. Because of this, the title of the settings page looks like this: settings.protected_branches - master - Gitea: Git with a cup of tea

The correct entry is repo.settings.protected_branch instead of repo.settings.protected_branches. With this change, the title looks like this: Branch Protection - master - Gitea: Git with a cup of tea


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/3694 **Author:** [@Chri-s](https://github.com/Chri-s) **Created:** 3/19/2018 **Status:** ✅ Merged **Merged:** 3/21/2018 **Merged by:** [@lafriks](https://github.com/lafriks) **Base:** `master` ← **Head:** `protected-branch-title-fix` --- ### 📝 Commits (5) - [`91098c4`](https://github.com/go-gitea/gitea/commit/91098c44aed1f8d0d460d6e7d7a6449d5ac0a84d) Change title to existing locale entry - [`2f56be0`](https://github.com/go-gitea/gitea/commit/2f56be0bb3dbb74f260cac8ab09979804d56dbf5) Merge branch 'master' into protected-branch-title-fix - [`6fbb039`](https://github.com/go-gitea/gitea/commit/6fbb039f310d05836f0e12404d82bf8306fdaf9e) Merge branch 'master' into protected-branch-title-fix - [`f596ed8`](https://github.com/go-gitea/gitea/commit/f596ed80ccf4175b4a3873d6bc48a23b42dcdf7b) Merge branch 'master' into protected-branch-title-fix - [`51c88d4`](https://github.com/go-gitea/gitea/commit/51c88d44410a97c659a482da899d84972f9db7bc) Merge branch 'master' into protected-branch-title-fix ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `routers/repo/setting_protected_branch.go` (+1 -1) </details> ### 📄 Description The title of the settings page for a protected branch references an invalid entry in the locale. Because of this, the title of the settings page looks like this: `settings.protected_branches - master - Gitea: Git with a cup of tea` The correct entry is `repo.settings.protected_branch` instead of `repo.settings.protected_branches`. With this change, the title looks like this: `Branch Protection - master - Gitea: Git with a cup of tea` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-02 12:25:03 -06:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#17047