github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-11 17:46:29 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

[PR #3564] [MERGED] Fix missing translations when updating username. #16998

New Issue
Closed
opened 2025-11-02 12:23:54 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-02 12:23:54 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/3564
Author: @bugreport0
Created: 2/22/2018
Status: ✅ Merged
Merged: 2/25/2018
Merged by: @lafriks

Base: master ← Head: patch-4

📝 Commits (5)

  • 25fda29 Fix missing translations when updating username.
  • 59c166d Fix reserved username translated string test.
  • 52be69b Merge branch 'master' into patch-4
  • 39eda45 Fix 'username reserved' string test a bit more.
  • 8c15ee9 Merge branch 'master' into patch-4

📊 Changes

2 files changed (+4 additions, -4 deletions)

View changed files

📝 integrations/user_test.go (+1 -1)
📝 routers/user/setting.go (+3 -3)

📄 Description

Gitea tries to display non-existing translation strings after failing to update a username on the 'Your Settings' page. This PR (hopefully) fixes three error cases. I'm no Go expert and I can't test this, but I think it should work.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/3564 **Author:** [@bugreport0](https://github.com/bugreport0) **Created:** 2/22/2018 **Status:** ✅ Merged **Merged:** 2/25/2018 **Merged by:** [@lafriks](https://github.com/lafriks) **Base:** `master` ← **Head:** `patch-4` --- ### 📝 Commits (5) - [`25fda29`](https://github.com/go-gitea/gitea/commit/25fda29df1e2da71eadf37c578ec79189e0cd58f) Fix missing translations when updating username. - [`59c166d`](https://github.com/go-gitea/gitea/commit/59c166d492d3ec3ca0a0e6e333c49b6c5da228aa) Fix reserved username translated string test. - [`52be69b`](https://github.com/go-gitea/gitea/commit/52be69ba6f9edfcbb8bba88353e4d225b7ea425d) Merge branch 'master' into patch-4 - [`39eda45`](https://github.com/go-gitea/gitea/commit/39eda454f5ead1b991f7f718b62ae482d3d4467f) Fix 'username reserved' string test a bit more. - [`8c15ee9`](https://github.com/go-gitea/gitea/commit/8c15ee9a1eb8f9c1b18a7fa87e8e17299135f9ed) Merge branch 'master' into patch-4 ### 📊 Changes **2 files changed** (+4 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `integrations/user_test.go` (+1 -1) 📝 `routers/user/setting.go` (+3 -3) </details> ### 📄 Description Gitea tries to display non-existing translation strings after failing to update a username on the 'Your Settings' page. This PR (hopefully) fixes three error cases. I'm no Go expert and I can't test this, but I think it should work. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-02 12:23:54 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#16998
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?