github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-10 13:56:06 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

[PR #3424] [MERGED] Fix SQL type error for webhooks #16937

New Issue
Closed
opened 2025-11-02 12:22:31 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-02 12:22:31 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/3424
Author: @ethantkoenig
Created: 1/28/2018
Status: ✅ Merged
Merged: 1/29/2018
Merged by: @lafriks

Base: master ← Head: fix/hook

📝 Commits (2)

  • 7de4857 Fix SQL type error for webhooks
  • 3fed3c0 add space to log msg

📊 Changes

1 file changed (+10 additions, -3 deletions)

View changed files

📝 models/webhook.go (+10 -3)

📄 Description

HookQueue contains strings, and we forget to convert the string to an int. As a result, webhooks are not properly fired (at least for MySQL, not sure about other RDBMSs)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/3424 **Author:** [@ethantkoenig](https://github.com/ethantkoenig) **Created:** 1/28/2018 **Status:** ✅ Merged **Merged:** 1/29/2018 **Merged by:** [@lafriks](https://github.com/lafriks) **Base:** `master` ← **Head:** `fix/hook` --- ### 📝 Commits (2) - [`7de4857`](https://github.com/go-gitea/gitea/commit/7de4857c0e53d3f72eebaee2ee6d8806f977900c) Fix SQL type error for webhooks - [`3fed3c0`](https://github.com/go-gitea/gitea/commit/3fed3c09b2686e12c8cc57eed4d57780acdf25d0) add space to log msg ### 📊 Changes **1 file changed** (+10 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `models/webhook.go` (+10 -3) </details> ### 📄 Description `HookQueue` contains strings, and we forget to convert the string to an int. As a result, webhooks are not properly fired (at least for MySQL, not sure about other RDBMSs) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-02 12:22:31 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#16937
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?