[PR #3395] [MERGED] Added quoting for passwords in sample.app.ini and documentation #16918

New Issue

GiteaMirror · 2025-11-02T12:22:06-06:00

GiteaMirror commented

2025-11-02 12:22:06 -06:00

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/3395
Author: @marove2000
Created: 1/19/2018
Status: ✅ Merged
Merged: 1/27/2018
Merged by: @lafriks

Base: master ← Head: master

📝 Commits (7)

233af8c added quote-hint for password to prevent erros parsing the .ini-file
ffc976d added quote-hint for password in documentation
44fe67c removed quotes from
df07f1e Merge branch 'master' into master
6537084 Merge branch 'master' into master
1d73277 Remove unneeded commas
0056704 Remove unneeded commas also in docs

📊 Changes

2 files changed (+5 additions, -2 deletions)

View changed files

📝 custom/conf/app.ini.sample (+3 -0)
📝 docs/content/doc/advanced/config-cheat-sheet.en-us.md (+2 -2)

📄 Description

This pull request is addressing issue #3380.

I've added quote hints in sample.app.ini and it's documentation, preventing wrong behavior when parsing the file if special characters are used in passwords.

Without quotes the password will be read wrong.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/3395 **Author:** [@marove2000](https://github.com/marove2000) **Created:** 1/19/2018 **Status:** ✅ Merged **Merged:** 1/27/2018 **Merged by:** [@lafriks](https://github.com/lafriks) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (7) - [`233af8c`](https://github.com/go-gitea/gitea/commit/233af8cb55f88f07fcdbf0a212535804150bc115) added quote-hint for password to prevent erros parsing the .ini-file - [`ffc976d`](https://github.com/go-gitea/gitea/commit/ffc976d1fcec6fb57048ac6d41f0abd85bb8b949) added quote-hint for password in documentation - [`44fe67c`](https://github.com/go-gitea/gitea/commit/44fe67c59cffb74a0ce05ef42443413173a25f8f) removed quotes from <empty> - [`df07f1e`](https://github.com/go-gitea/gitea/commit/df07f1e46e99e3f23c3752c3f4ff1f1c20299da8) Merge branch 'master' into master - [`6537084`](https://github.com/go-gitea/gitea/commit/6537084bf87f93197c783d2c8110730fd3ceaed4) Merge branch 'master' into master - [`1d73277`](https://github.com/go-gitea/gitea/commit/1d73277270596b907c8f2b0c9a5bcb38a2387c4c) Remove unneeded commas - [`0056704`](https://github.com/go-gitea/gitea/commit/005670402069ec4baab8fff66bcfe134f29527a2) Remove unneeded commas also in docs ### 📊 Changes **2 files changed** (+5 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `custom/conf/app.ini.sample` (+3 -0) 📝 `docs/content/doc/advanced/config-cheat-sheet.en-us.md` (+2 -2) </details> ### 📄 Description This pull request is addressing issue #3380. I've added quote hints in sample.app.ini and it's documentation, preventing wrong behavior when parsing the file if special characters are used in passwords. Without quotes the password will be read wrong. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-02 12:22:06 -06:00

GiteaMirror closed this issue

2025-11-02 12:22:06 -06:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#16918