github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-12 02:24:21 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

Members removed from team/repository keep watches #1690

New Issue
Closed
opened 2025-11-02 04:09:42 -06:00 by GiteaMirror · 7 comments
GiteaMirror commented 2025-11-02 04:09:42 -06:00
Owner
Copy Link

Originally created by @michaelkuhn on GitHub (Apr 10, 2018).

Description

When removing members from a team, they lose access to the respective repositories but keep their watches on the repository. This allows them to receive notifications via e-mail even if they should not be able to access the repository.

Reproducer (see link above): I added lunny to the test team, gave the team access to the repository and then removed lunny again. He still has a watch on the repository.

Originally created by @michaelkuhn on GitHub (Apr 10, 2018). - Gitea version (or commit ref): 38a9cda - Can you reproduce the bug at https://try.gitea.io: - [x] Yes: https://try.gitea.io/7tl9ebtg7mio/test ## Description When removing members from a team, they lose access to the respective repositories but keep their watches on the repository. This allows them to receive notifications via e-mail even if they should not be able to access the repository. Reproducer (see link above): I added lunny to the test team, gave the team access to the repository and then removed lunny again. He still has a watch on the repository.
GiteaMirror added the type/bugtopic/security labels 2025-11-02 04:09:42 -06:00
GiteaMirror commented 2025-11-02 04:09:43 -06:00
Author
Owner
Copy Link

@mqudsi commented on GitHub (Apr 14, 2018):

This should be tagged with a security label and perhaps assigned a CVE.

@mqudsi commented on GitHub (Apr 14, 2018): This should be tagged with a security label and perhaps assigned a CVE.
GiteaMirror commented 2025-11-02 04:09:43 -06:00
Author
Owner
Copy Link

@lunny commented on GitHub (Apr 15, 2018):

@mqudsi it will only show the wrong watch but there is no wrong permission.

@lunny commented on GitHub (Apr 15, 2018): @mqudsi it will only show the wrong watch but there is no wrong permission.
GiteaMirror commented 2025-11-02 04:09:43 -06:00
Author
Owner
Copy Link

@mqudsi commented on GitHub (Apr 15, 2018):

@lunny thanks, that's much better :)

@mqudsi commented on GitHub (Apr 15, 2018): @lunny thanks, that's much better :)
GiteaMirror commented 2025-11-02 04:09:44 -06:00
Author
Owner
Copy Link

@michaelkuhn commented on GitHub (May 16, 2018):

From what I could tell, removed members will still get notification e-mails (including the full comments) for issues etc. While the removed members do not have access to the repository anymore, they may still get information they should not get.

@michaelkuhn commented on GitHub (May 16, 2018): From what I could tell, removed members will still get notification e-mails (including the full comments) for issues etc. While the removed members do not have access to the repository anymore, they may still get information they should not get.
GiteaMirror commented 2025-11-02 04:09:44 -06:00
Author
Owner
Copy Link

@axifive commented on GitHub (May 16, 2018):

Perhaps need to add security or priority label?

@axifive commented on GitHub (May 16, 2018): Perhaps need to add security or priority label?
GiteaMirror commented 2025-11-02 04:09:44 -06:00
Author
Owner
Copy Link

@daviian commented on GitHub (Jun 5, 2018):

Just wanted to mention that I'm already working on it. Including https://github.com/go-gitea/gitea/issues/3343 and https://github.com/go-gitea/gitea/issues/4149, because it's closely related

@daviian commented on GitHub (Jun 5, 2018): Just wanted to mention that I'm already working on it. Including https://github.com/go-gitea/gitea/issues/3343 and https://github.com/go-gitea/gitea/issues/4149, because it's closely related
GiteaMirror commented 2025-11-02 04:09:44 -06:00
Author
Owner
Copy Link

@techknowlogick commented on GitHub (Jun 19, 2018):

Closed with #4201

@techknowlogick commented on GitHub (Jun 19, 2018): Closed with #4201
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label topic/security type/bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#1690
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?