github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-11 17:46:29 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

[PR #3334] [MERGED] Cleanup models.User.HashPassword #16892

New Issue
Closed
opened 2025-11-02 12:21:30 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-02 12:21:30 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/3334
Author: @bkcsoft
Created: 1/8/2018
Status: ✅ Merged
Merged: 1/11/2018
Merged by: @lafriks

Base: master ← Head: cleanup-user-hashpassword

📝 Commits (3)

  • 3435bf7 Cleanup models.User.HashPassword
  • a998961 Remove unneeded variable
  • 7de35ca Merge branch 'master' into cleanup-user-hashpassword

📊 Changes

7 files changed (+18 additions, -23 deletions)

View changed files

📝 cmd/admin.go (+1 -2)
📝 models/user.go (+10 -7)
📝 models/user_test.go (+3 -6)
📝 routers/admin/users.go (+1 -2)
📝 routers/api/v1/admin/user.go (+1 -2)
📝 routers/user/auth.go (+1 -2)
📝 routers/user/setting.go (+1 -2)

📄 Description

Makes it deterministic even if ran twice.

Something like this would previously break the users password:

u.Passwd = "foobar"
u.HashPassword()
u.HashPassword()

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/3334 **Author:** [@bkcsoft](https://github.com/bkcsoft) **Created:** 1/8/2018 **Status:** ✅ Merged **Merged:** 1/11/2018 **Merged by:** [@lafriks](https://github.com/lafriks) **Base:** `master` ← **Head:** `cleanup-user-hashpassword` --- ### 📝 Commits (3) - [`3435bf7`](https://github.com/go-gitea/gitea/commit/3435bf72bf224362fd8c57ee2251ab97d53c6068) Cleanup models.User.HashPassword - [`a998961`](https://github.com/go-gitea/gitea/commit/a99896175d4ed1b7fe31e1e0bfc38efbac46c92a) Remove unneeded variable - [`7de35ca`](https://github.com/go-gitea/gitea/commit/7de35ca58e03b02dcb8a244c71ffd4961b3d5c27) Merge branch 'master' into cleanup-user-hashpassword ### 📊 Changes **7 files changed** (+18 additions, -23 deletions) <details> <summary>View changed files</summary> 📝 `cmd/admin.go` (+1 -2) 📝 `models/user.go` (+10 -7) 📝 `models/user_test.go` (+3 -6) 📝 `routers/admin/users.go` (+1 -2) 📝 `routers/api/v1/admin/user.go` (+1 -2) 📝 `routers/user/auth.go` (+1 -2) 📝 `routers/user/setting.go` (+1 -2) </details> ### 📄 Description Makes it deterministic even if ran twice. Something like this would previously break the users password: ``` u.Passwd = "foobar" u.HashPassword() u.HashPassword() ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-02 12:21:30 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#16892
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?