[PR #3322] [MERGED] Ensure docs makefile downloads theme if failed before. #16884

New Issue

GiteaMirror · 2025-11-02T12:21:19-06:00

GiteaMirror commented

2025-11-02 12:21:19 -06:00

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/3322
Author: @AlbertoGP
Created: 1/7/2018
Status: ✅ Merged
Merged: 1/7/2018
Merged by: @lafriks

Base: master ← Head: docs-makefile-3306

📝 Commits (2)

4213999 Ensure docs makefile downloads theme if failed before.
be2d09f Merge branch 'master' into docs-makefile-3306

📊 Changes

1 file changed (+4 additions, -3 deletions)

View changed files

📝 docs/Makefile (+4 -3)

📄 Description

Fixes #3306 Documentation build: Partial "header.html" not found.

If the theme archive download fails, an empty theme directory gets left there, and on subsequent runs the makefile will not attempt to download it again.

This change makes the theme target depend on the "theme.toml" file which will only be there after unpacking the theme file.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/3322 **Author:** [@AlbertoGP](https://github.com/AlbertoGP) **Created:** 1/7/2018 **Status:** ✅ Merged **Merged:** 1/7/2018 **Merged by:** [@lafriks](https://github.com/lafriks) **Base:** `master` ← **Head:** `docs-makefile-3306` --- ### 📝 Commits (2) - [`4213999`](https://github.com/go-gitea/gitea/commit/42139993b6a1261533ffac7ca31fb8b8bc670569) Ensure docs makefile downloads theme if failed before. - [`be2d09f`](https://github.com/go-gitea/gitea/commit/be2d09feb8d199a6fe619b93fc7501dc29363b02) Merge branch 'master' into docs-makefile-3306 ### 📊 Changes **1 file changed** (+4 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `docs/Makefile` (+4 -3) </details> ### 📄 Description Fixes #3306 Documentation build: Partial "header.html" not found. If the theme archive download fails, an empty theme directory gets left there, and on subsequent runs the makefile will not attempt to download it again. This change makes the theme target depend on the "theme.toml" file which will only be there after unpacking the theme file. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-02 12:21:19 -06:00

GiteaMirror closed this issue

2025-11-02 12:21:19 -06:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#16884