[PR #3177] [MERGED] Fix ignored errors when checking if organization, team member #16816

Closed
opened 2025-11-02 12:19:45 -06:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/3177
Author: @ethantkoenig
Created: 12/13/2017
Status: Merged
Merged: 12/21/2017
Merged by: @lafriks

Base: masterHead: ignored_errors


📝 Commits (2)

  • 6b1948e Fix ignored errors
  • e75a2fd Merge branch 'master' into ignored_errors

📊 Changes

16 files changed (+281 additions, -144 deletions)

View changed files

📝 models/org.go (+21 -18)
📝 models/org_team.go (+20 -11)
📝 models/org_team_test.go (+12 -7)
📝 models/org_test.go (+66 -35)
📝 models/repo.go (+10 -4)
📝 models/user.go (+12 -2)
📝 modules/context/org.go (+10 -3)
📝 routers/api/v1/api.go (+8 -2)
📝 routers/api/v1/org/member.go (+30 -11)
📝 routers/api/v1/org/team.go (+5 -1)
📝 routers/api/v1/repo/fork.go (+5 -1)
📝 routers/api/v1/repo/repo.go (+32 -7)
📝 routers/repo/issue.go (+24 -8)
📝 routers/repo/pull.go (+5 -1)
📝 routers/repo/repo.go (+11 -1)
📝 routers/repo/setting.go (+10 -32)

📄 Description

  • Add checks for previously-ignored errors in various org functions.
  • Get(..) -> Exist() micro-optimization
  • Remove unnecessary checks in repo.SettingsPost(..)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/3177 **Author:** [@ethantkoenig](https://github.com/ethantkoenig) **Created:** 12/13/2017 **Status:** ✅ Merged **Merged:** 12/21/2017 **Merged by:** [@lafriks](https://github.com/lafriks) **Base:** `master` ← **Head:** `ignored_errors` --- ### 📝 Commits (2) - [`6b1948e`](https://github.com/go-gitea/gitea/commit/6b1948ea7ef0744ef930c2a5f667fd284e903dcd) Fix ignored errors - [`e75a2fd`](https://github.com/go-gitea/gitea/commit/e75a2fdef6711744d3d0cb7b55465a7983cfc098) Merge branch 'master' into ignored_errors ### 📊 Changes **16 files changed** (+281 additions, -144 deletions) <details> <summary>View changed files</summary> 📝 `models/org.go` (+21 -18) 📝 `models/org_team.go` (+20 -11) 📝 `models/org_team_test.go` (+12 -7) 📝 `models/org_test.go` (+66 -35) 📝 `models/repo.go` (+10 -4) 📝 `models/user.go` (+12 -2) 📝 `modules/context/org.go` (+10 -3) 📝 `routers/api/v1/api.go` (+8 -2) 📝 `routers/api/v1/org/member.go` (+30 -11) 📝 `routers/api/v1/org/team.go` (+5 -1) 📝 `routers/api/v1/repo/fork.go` (+5 -1) 📝 `routers/api/v1/repo/repo.go` (+32 -7) 📝 `routers/repo/issue.go` (+24 -8) 📝 `routers/repo/pull.go` (+5 -1) 📝 `routers/repo/repo.go` (+11 -1) 📝 `routers/repo/setting.go` (+10 -32) </details> ### 📄 Description - Add checks for previously-ignored errors in various org functions. - `Get(..)` -> `Exist()` micro-optimization - Remove unnecessary checks in `repo.SettingsPost(..)` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-02 12:19:45 -06:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#16816