[PR #3156] [MERGED] Fix Uninitialized variable in ParsePatch #16801

New Issue

GiteaMirror · 2025-11-02T12:19:26-06:00

GiteaMirror commented

2025-11-02 12:19:26 -06:00

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/3156
Author: @bkcsoft
Created: 12/11/2017
Status: ✅ Merged
Merged: 12/12/2017
Merged by: @lafriks

Base: master ← Head: parse-patch-uninitialized-var

📝 Commits (1)

1795873 Fix Uninitialized variable in ParsePatch

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 models/git_diff.go (+1 -1)

📄 Description

Fix a bug reported on Discord.

top of stack trace:

    [Macaron] PANIC: runtime error: invalid memory address or nil pointer dereference
    /usr/local/go/src/runtime/panic.go:489 (0x428a6a)
    /usr/local/go/src/runtime/panic.go:63 (0x427c0c)
    /usr/local/go/src/runtime/signal_windows.go:161 (0x43a624)
    /srv/app/src/code.gitea.io/gitea/models/git_diff.go:350 (0xb5eb8f)
    /srv/app/src/code.gitea.io/gitea/models/git_diff.go:495 (0xb609b9)
    /srv/app/src/code.gitea.io/gitea/models/git_diff.go:564 (0xb614e1)
    /srv/app/src/code.gitea.io/gitea/routers/repo/commit.go:213 (0xca6979)

Bug in https://github.com/go-gitea/gitea/blob/release/v1.3/models/git_diff.go#L341 because https://github.com/go-gitea/gitea/blob/release/v1.3/models/git_diff.go#L241 is never initialized.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/3156 **Author:** [@bkcsoft](https://github.com/bkcsoft) **Created:** 12/11/2017 **Status:** ✅ Merged **Merged:** 12/12/2017 **Merged by:** [@lafriks](https://github.com/lafriks) **Base:** `master` ← **Head:** `parse-patch-uninitialized-var` --- ### 📝 Commits (1) - [`1795873`](https://github.com/go-gitea/gitea/commit/1795873de6359c6ca8ed64c7c6ad23c056f42409) Fix Uninitialized variable in ParsePatch ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `models/git_diff.go` (+1 -1) </details> ### 📄 Description Fix a bug reported on Discord. ``` top of stack trace: [Macaron] PANIC: runtime error: invalid memory address or nil pointer dereference /usr/local/go/src/runtime/panic.go:489 (0x428a6a) /usr/local/go/src/runtime/panic.go:63 (0x427c0c) /usr/local/go/src/runtime/signal_windows.go:161 (0x43a624) /srv/app/src/code.gitea.io/gitea/models/git_diff.go:350 (0xb5eb8f) /srv/app/src/code.gitea.io/gitea/models/git_diff.go:495 (0xb609b9) /srv/app/src/code.gitea.io/gitea/models/git_diff.go:564 (0xb614e1) /srv/app/src/code.gitea.io/gitea/routers/repo/commit.go:213 (0xca6979) ``` Bug in https://github.com/go-gitea/gitea/blob/release/v1.3/models/git_diff.go#L341 because https://github.com/go-gitea/gitea/blob/release/v1.3/models/git_diff.go#L241 is never initialized. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-02 12:19:26 -06:00

GiteaMirror closed this issue

2025-11-02 12:19:26 -06:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#16801