[PR #3138] [MERGED] Log unexpected responses in integration tests #16788

Closed
opened 2025-11-02 12:19:08 -06:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/3138
Author: @ethantkoenig
Created: 12/10/2017
Status: Merged
Merged: 12/11/2017
Merged by: @lunny

Base: masterHead: tests/log_err_msg


📝 Commits (4)

  • ea87aa6 Log flash error message in integration tests
  • a58ae6e Also log short, non-HTML responses
  • 7ce3b12 Merge branch 'master' into tests/log_err_msg
  • f806ea3 Merge branch 'master' into tests/log_err_msg

📊 Changes

1 file changed (+28 additions, -2 deletions)

View changed files

📝 integrations/integration_test.go (+28 -2)

📄 Description

When an integration tests receives an unexpected status, log the response.

Either log the entire response if it is short, or log the HTML flash error message (if there is one). This will help in debugging spurious test failures (e.g. https://drone.gitea.io/go-gitea/gitea/2501/9).


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/3138 **Author:** [@ethantkoenig](https://github.com/ethantkoenig) **Created:** 12/10/2017 **Status:** ✅ Merged **Merged:** 12/11/2017 **Merged by:** [@lunny](https://github.com/lunny) **Base:** `master` ← **Head:** `tests/log_err_msg` --- ### 📝 Commits (4) - [`ea87aa6`](https://github.com/go-gitea/gitea/commit/ea87aa6ae9547df441de42bd4850c988602b0bf5) Log flash error message in integration tests - [`a58ae6e`](https://github.com/go-gitea/gitea/commit/a58ae6e570ce79e1df734784a9c0f8dee4618f5c) Also log short, non-HTML responses - [`7ce3b12`](https://github.com/go-gitea/gitea/commit/7ce3b12f9ce1311196a66356574daf81ba869207) Merge branch 'master' into tests/log_err_msg - [`f806ea3`](https://github.com/go-gitea/gitea/commit/f806ea38743fe1cdcd21a1b86a9adf88def7bf31) Merge branch 'master' into tests/log_err_msg ### 📊 Changes **1 file changed** (+28 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `integrations/integration_test.go` (+28 -2) </details> ### 📄 Description When an integration tests receives an unexpected status, log the response. Either log the entire response if it is short, or log the HTML flash error message (if there is one). This will help in debugging spurious test failures (e.g. https://drone.gitea.io/go-gitea/gitea/2501/9). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-02 12:19:08 -06:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#16788