github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-09 04:25:18 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

[PR #3104] [MERGED] Rework button styles on repo and commit page #16768

New Issue
Closed
opened 2025-11-02 12:18:40 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-02 12:18:40 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/3104
Author: @silverwind
Created: 12/6/2017
Status: ✅ Merged
Merged: 12/7/2017
Merged by: @appleboy

Base: master ← Head: fix-buttons

📝 Commits (1)

  • 0ce57ce Rework button styles on repo and commit page

📊 Changes

3 files changed (+9 additions, -7 deletions)

View changed files

📝 public/css/index.css (+1 -1)
📝 public/less/_base.less (+7 -5)
📝 templates/repo/commits.tmpl (+1 -1)

📄 Description

My fix in https://github.com/go-gitea/gitea/pull/3091 introduced an issue on some buttons because Semantic unexpectedly sets a font-size of 0 in some places, which breaks em units on children. I changed the way of overriding the selector to now target small or compact buttons specifically and reset their value to what it originally is. Results:

screen shot 2017-12-06 at 20 50 12 screen shot 2017-12-06 at 20 50 19 screen shot 2017-12-06 at 20 59 21

Fixes: https://github.com/go-gitea/gitea/issues/3094

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/3104 **Author:** [@silverwind](https://github.com/silverwind) **Created:** 12/6/2017 **Status:** ✅ Merged **Merged:** 12/7/2017 **Merged by:** [@appleboy](https://github.com/appleboy) **Base:** `master` ← **Head:** `fix-buttons` --- ### 📝 Commits (1) - [`0ce57ce`](https://github.com/go-gitea/gitea/commit/0ce57ceea13017317f898b1a5f2fc8039860c124) Rework button styles on repo and commit page ### 📊 Changes **3 files changed** (+9 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `public/css/index.css` (+1 -1) 📝 `public/less/_base.less` (+7 -5) 📝 `templates/repo/commits.tmpl` (+1 -1) </details> ### 📄 Description My fix in https://github.com/go-gitea/gitea/pull/3091 introduced an issue on some buttons because Semantic unexpectedly sets a font-size of `0` in some places, which breaks `em` units on children. I changed the way of overriding the selector to now target small or compact buttons specifically and reset their value to what it originally is. Results: <img width="287" alt="screen shot 2017-12-06 at 20 50 12" src="https://user-images.githubusercontent.com/115237/33682403-a167459e-dac7-11e7-87fa-b0990ea0b335.png"> <img width="396" alt="screen shot 2017-12-06 at 20 50 19" src="https://user-images.githubusercontent.com/115237/33682404-a18b6898-dac7-11e7-9b27-648cb694c5c7.png"> <img width="329" alt="screen shot 2017-12-06 at 20 59 21" src="https://user-images.githubusercontent.com/115237/33682632-60268d14-dac8-11e7-9211-61b3879729d6.png"> Fixes: https://github.com/go-gitea/gitea/issues/3094 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-02 12:18:40 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#16768
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?