[PR #3091] [MERGED] fix button heights on commits page #16761

New Issue

GiteaMirror · 2025-11-02T12:18:30-06:00

GiteaMirror commented

2025-11-02 12:18:30 -06:00

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/3091
Author: @silverwind
Created: 12/4/2017
Status: ✅ Merged
Merged: 12/5/2017
Merged by: @lunny

Base: master ← Head: commits-buttons

📝 Commits (2)

2f6f5a7 fix button heights on commits page
6d61f2c Merge branch 'master' into commits-buttons

📊 Changes

2 files changed (+13 additions, -6 deletions)

View changed files

📝 public/css/index.css (+1 -1)
📝 public/less/_base.less (+12 -5)

📄 Description

Fixes a issue I introduced by changing the branch button. Basically, Semantic uses the selector .ui.menu:not(.vertical) .item > .button which does not work if .button is no direct child of .item which is the case for the branch button in our case, because it's wrapped in a dropdown.

Additionally, I fixed a indendation issue I introduced earlier while merging.

Before

After

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/3091 **Author:** [@silverwind](https://github.com/silverwind) **Created:** 12/4/2017 **Status:** ✅ Merged **Merged:** 12/5/2017 **Merged by:** [@lunny](https://github.com/lunny) **Base:** `master` ← **Head:** `commits-buttons` --- ### 📝 Commits (2) - [`2f6f5a7`](https://github.com/go-gitea/gitea/commit/2f6f5a712b820c2d26d78bbad6a72081b4d6f445) fix button heights on commits page - [`6d61f2c`](https://github.com/go-gitea/gitea/commit/6d61f2ca769f1cdc0e67a9e04b4b2b9764ce8b84) Merge branch 'master' into commits-buttons ### 📊 Changes **2 files changed** (+13 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `public/css/index.css` (+1 -1) 📝 `public/less/_base.less` (+12 -5) </details> ### 📄 Description Fixes a issue I introduced by changing the branch button. Basically, Semantic uses the selector `.ui.menu:not(.vertical) .item > .button` which does not work if `.button` is no direct child of `.item` which is the case for the branch button in our case, because it's wrapped in a dropdown. Additionally, I fixed a indendation issue I introduced earlier while merging. #### Before <img width="419" alt="screen shot 2017-12-04 at 18 52 22" src="https://user-images.githubusercontent.com/115237/33567710-5f6bf27e-d924-11e7-87b6-45b8985d55d8.png"> #### After <img width="429" alt="screen shot 2017-12-04 at 19 06 06" src="https://user-images.githubusercontent.com/115237/33568272-38a91e94-d926-11e7-8414-66438d419701.png"> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-02 12:18:30 -06:00

GiteaMirror closed this issue

2025-11-02 12:18:30 -06:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#16761