[PR #3090] [MERGED] add quotation around ports in docker-compose.yml #16760

New Issue

GiteaMirror · 2025-11-02T12:18:28-06:00

GiteaMirror commented

2025-11-02 12:18:28 -06:00

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/3090
Author: @bibaijin
Created: 12/4/2017
Status: ✅ Merged
Merged: 12/5/2017
Merged by: @lunny

Base: master ← Head: master

📝 Commits (3)

e94e084 add quotation around ports in docker-compose.yml
f3de616 Merge branch 'master' into master
ecb97cf Merge branch 'master' into master

📊 Changes

1 file changed (+12 additions, -12 deletions)

View changed files

📝 docs/content/doc/installation/with-docker.en-us.md (+12 -12)

📄 Description

Without quotation around ports in docker-compose.yml, an error will occur when docker-compose up:

Creating network "test_gitea" with the default driver                                                                                            
Creating volume "test_gitea" with local driver                                                                                                   
Creating test_server_1 ...                                                                                                                       
Creating test_server_1 ... error
                                                                                                                                                 
ERROR: for test_server_1  Cannot create container for service server: b'invalid port specification: "601342"'

ERROR: for server  Cannot create container for service server: b'invalid port specification: "601342"'
ERROR: Encountered errors while bringing up the project.

According to yaml's specification, : is a special mark, which denotes map, so quotation is necessary to avoid ambiguity.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/3090 **Author:** [@bibaijin](https://github.com/bibaijin) **Created:** 12/4/2017 **Status:** ✅ Merged **Merged:** 12/5/2017 **Merged by:** [@lunny](https://github.com/lunny) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (3) - [`e94e084`](https://github.com/go-gitea/gitea/commit/e94e0848b687302e9289d3f53cac60e9ac82dd67) add quotation around ports in docker-compose.yml - [`f3de616`](https://github.com/go-gitea/gitea/commit/f3de6165398a993f0a2e1879d1f2f8045defae88) Merge branch 'master' into master - [`ecb97cf`](https://github.com/go-gitea/gitea/commit/ecb97cfe7cfef207b157d4e124c6eee6e5b3ff46) Merge branch 'master' into master ### 📊 Changes **1 file changed** (+12 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `docs/content/doc/installation/with-docker.en-us.md` (+12 -12) </details> ### 📄 Description Without quotation around ports in docker-compose.yml, an error will occur when `docker-compose up`: ``` Creating network "test_gitea" with the default driver Creating volume "test_gitea" with local driver Creating test_server_1 ... Creating test_server_1 ... error ERROR: for test_server_1 Cannot create container for service server: b'invalid port specification: "601342"' ERROR: for server Cannot create container for service server: b'invalid port specification: "601342"' ERROR: Encountered errors while bringing up the project. ``` According to yaml's specification, `:` is a special mark, which denotes map, so quotation is necessary to avoid ambiguity. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-02 12:18:28 -06:00

GiteaMirror closed this issue

2025-11-02 12:18:29 -06:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#16760