[PR #3073] [MERGED] Fix bugs in issue dashboard stats #16748

Closed
opened 2025-11-02 12:18:10 -06:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/3073
Author: @ethantkoenig
Created: 12/3/2017
Status: Merged
Merged: 12/25/2017
Merged by: @lafriks

Base: masterHead: fix/issue_stats


📝 Commits (3)

  • 8753746 Fix bugs in issue dashboard stats
  • a983faf Merge branch 'master' into fix/issue_stats
  • 21f58b0 Merge branch 'master' into fix/issue_stats

📊 Changes

7 files changed (+224 additions, -55 deletions)

View changed files

📝 models/fixtures/issue.yml (+6 -1)
📝 models/issue.go (+77 -45)
📝 models/issue_indexer.go (+1 -1)
📝 models/issue_test.go (+111 -0)
📝 routers/api/v1/repo/issue.go (+1 -1)
📝 routers/repo/issue.go (+1 -1)
📝 routers/user/home.go (+27 -6)

📄 Description

Fixes the following bugs in the issue dashboard:

  • Previously, the "In your Repositories", "Assigned to you" and "Created to you" counts would show the stats for open issues, even if closed issues were selected
  • Previously, the "In your Repositories" count would be incorrect when a repo that is not yours is selected (the count should be 0, because of all the issues currently in view, none are in repos that are yours)
  • Previously, simultaneously selecting "In your Repositories" and a repo that is not yours would result in all the issues in that repo being displayed (no issues should be displayed, since none of the issues in that repo are in repos that are yours)

Also fixes ignored errors in GetUserIssueStats(..), and adds unit tests for affected functionality.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/3073 **Author:** [@ethantkoenig](https://github.com/ethantkoenig) **Created:** 12/3/2017 **Status:** ✅ Merged **Merged:** 12/25/2017 **Merged by:** [@lafriks](https://github.com/lafriks) **Base:** `master` ← **Head:** `fix/issue_stats` --- ### 📝 Commits (3) - [`8753746`](https://github.com/go-gitea/gitea/commit/8753746d9d489ca53f7427f12bcd8ec6fa334ac3) Fix bugs in issue dashboard stats - [`a983faf`](https://github.com/go-gitea/gitea/commit/a983faf0b979507794efcf5f80e2a1e1b95e2842) Merge branch 'master' into fix/issue_stats - [`21f58b0`](https://github.com/go-gitea/gitea/commit/21f58b0acba05b09d2ef54aa6b8945e1117cf0d0) Merge branch 'master' into fix/issue_stats ### 📊 Changes **7 files changed** (+224 additions, -55 deletions) <details> <summary>View changed files</summary> 📝 `models/fixtures/issue.yml` (+6 -1) 📝 `models/issue.go` (+77 -45) 📝 `models/issue_indexer.go` (+1 -1) 📝 `models/issue_test.go` (+111 -0) 📝 `routers/api/v1/repo/issue.go` (+1 -1) 📝 `routers/repo/issue.go` (+1 -1) 📝 `routers/user/home.go` (+27 -6) </details> ### 📄 Description Fixes the following bugs in the issue dashboard: * Previously, the "In your Repositories", "Assigned to you" and "Created to you" counts would show the stats for open issues, even if closed issues were selected * Previously, the "In your Repositories" count would be incorrect when a repo that is not yours is selected (the count should be 0, because of all the issues currently in view, none are in repos that are yours) * Previously, simultaneously selecting "In your Repositories" and a repo that is not yours would result in all the issues in that repo being displayed (no issues should be displayed, since none of the issues in that repo are in repos that are yours) Also fixes ignored errors in `GetUserIssueStats(..)`, and adds unit tests for affected functionality. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-02 12:18:10 -06:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#16748