[PR #3044] [MERGED] sendmail: correct option to set envelope-sender #16732

New Issue

GiteaMirror · 2025-11-02T12:17:40-06:00

GiteaMirror commented

2025-11-02 12:17:40 -06:00

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/3044
Author: @stesachse
Created: 12/1/2017
Status: ✅ Merged
Merged: 12/2/2017
Merged by: @lunny

Base: release/v1.3 ← Head: fix-sendmail-envelope-sender

📝 Commits (1)

244fb3a sendmail: correct option to set envelope-sender

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 modules/mailer/mailer.go (+1 -1)

📄 Description

mailer doesn't set the correct options while calling sendmail. if
mailer.FROM is set to "Gitea Webservice" <user@example.com>
sendmail is called like this

Sending with: sendmail [-F user@example.com -i alice@example.com]

and doesn't set the envelope-sender. the option -F string set the
sender full name and is used only with messages that has no From
message header.

set the envelope sender address with -f sender (lowercase f)
works for me (fedora 27, x86_64, postfix-3.2.4, go1.9.1, gitea-1.3.0)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/3044 **Author:** [@stesachse](https://github.com/stesachse) **Created:** 12/1/2017 **Status:** ✅ Merged **Merged:** 12/2/2017 **Merged by:** [@lunny](https://github.com/lunny) **Base:** `release/v1.3` ← **Head:** `fix-sendmail-envelope-sender` --- ### 📝 Commits (1) - [`244fb3a`](https://github.com/go-gitea/gitea/commit/244fb3ab025ed8c15d1a8838a547e8396674b1ff) sendmail: correct option to set envelope-sender ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `modules/mailer/mailer.go` (+1 -1) </details> ### 📄 Description mailer doesn't set the correct options while calling sendmail. if ``mailer.FROM`` is set to ``"Gitea Webservice" <user@example.com>`` sendmail is called like this ``Sending with: sendmail [-F user@example.com -i alice@example.com]`` and doesn't set the envelope-sender. the option ``-F string`` set the sender full name and is used only with messages that has no ``From`` message header. set the envelope sender address with ``-f sender`` (lowercase ``f``) works for me (fedora 27, x86_64, postfix-3.2.4, go1.9.1, gitea-1.3.0) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-02 12:17:40 -06:00

GiteaMirror closed this issue

2025-11-02 12:17:41 -06:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#16732