[PR #2927] [MERGED] Docker multi-stage #16668

Closed
opened 2025-11-02 12:15:57 -06:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/2927
Author: @sapk
Created: 11/16/2017
Status: Merged
Merged: 3/12/2018
Merged by: @lafriks

Base: masterHead: docker-multi-stage


📝 Commits (5)

  • 94ca7e0 Setup docker multi-stage and little sugar at it
  • 1fa605e Make codacy happy ?
  • 1dcd41e Revert back to what the official docker documentation suggest
  • 3825a13 Merge branch 'master' into docker-multi-stage
  • 25d4d4f Update golang version

📊 Changes

3 files changed (+34 additions, -15 deletions)

View changed files

.dockerignore (+0 -5)
📝 Dockerfile (+29 -9)
📝 docker/Makefile (+5 -1)

📄 Description

Permit to do directly docker build . in repo root. since binary is build at first stage and COPY in the exported image. Resolve #2879

In addition :

  • permit to chose the version of the binary build via --build-arg GITEA_VERSION=v1.2.3
  • permit to chose the tags of the binary build via --build-arg TAGS="bindata sqlite"

I kept make docker-build if some people use docker to build the binary.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/2927 **Author:** [@sapk](https://github.com/sapk) **Created:** 11/16/2017 **Status:** ✅ Merged **Merged:** 3/12/2018 **Merged by:** [@lafriks](https://github.com/lafriks) **Base:** `master` ← **Head:** `docker-multi-stage` --- ### 📝 Commits (5) - [`94ca7e0`](https://github.com/go-gitea/gitea/commit/94ca7e0d75a5252b395c99d00247df791736f6f3) Setup docker multi-stage and little sugar at it - [`1fa605e`](https://github.com/go-gitea/gitea/commit/1fa605e817fb6ca3ce3f85183323d12ec7637af1) Make codacy happy ? - [`1dcd41e`](https://github.com/go-gitea/gitea/commit/1dcd41ec9ba74dbc4db9939abe29fd2e6d64c06b) Revert back to what the official docker documentation suggest - [`3825a13`](https://github.com/go-gitea/gitea/commit/3825a138f45decc4ffc06b150bc9b3f4c3725f92) Merge branch 'master' into docker-multi-stage - [`25d4d4f`](https://github.com/go-gitea/gitea/commit/25d4d4f95184b11a868c22cc7749849b830aa1de) Update golang version ### 📊 Changes **3 files changed** (+34 additions, -15 deletions) <details> <summary>View changed files</summary> ➖ `.dockerignore` (+0 -5) 📝 `Dockerfile` (+29 -9) 📝 `docker/Makefile` (+5 -1) </details> ### 📄 Description Permit to do directly `docker build .` in repo root. since binary is build at first stage and COPY in the exported image. Resolve #2879 In addition : + permit to chose the version of the binary build via --build-arg GITEA_VERSION=v1.2.3 + permit to chose the tags of the binary build via --build-arg TAGS="bindata sqlite" I kept `make docker-build` if some people use docker to build the binary. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-02 12:15:57 -06:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#16668