Unix socket: cannot pull/push over SSH #1664

New Issue

GiteaMirror · 2025-11-02T04:08:52-06:00

GiteaMirror commented

2025-11-02 04:08:52 -06:00

Originally created by @sloonz on GitHub (Mar 29, 2018).

Gitea version (or commit ref): 1.4.0
Git version: 2.16.3
Go version: 1.10
Operating system: ArchLinux
Database (use [x]):
- PostgreSQL
- MySQL
- MSSQL
- SQLite
Can you reproduce the bug at https://try.gitea.io:
- Yes (provide example URL)
- No
- Not relevant

Description

With the following configuration (actual domain redacted by example.com) in the [server] section:

PROTOCOL                   = unix
HTTP_ADDR                  = /run/nginx/gitea.sock
DOMAIN                     = git.example.com
ROOT_URL                   = https://git.example.com/
LOCAL_ROOT_URL = %(PROTOCOL)s://%(HTTP_ADDR)s:%(HTTP_PORT)s/

Trying to perform a git pull/push via SSH results in an error :

UpdatePublicKey: Post unix:///run/nginx/gitea.sockapi/internal/ssh/1/update: unsupported protocol scheme "unix"

Looks like a regression over https://github.com/go-gitea/gitea/issues/2232, which has been fixed months ago. Adding some good old Printf traces in the code, I can see that req.SetTransport is called in newInternalRequest, but the Dial function that is set up there is never called ; the error is encountered before then. Changing LOCAL_ROOT_URL to http://%(DOMAIN)s/ fixes the issue : both the req.SetTransport and Dial functions are called, and the request is performed on the unix socket (no log in the reverse proxy that’s listening on https://git.example.com/, and adding deny all on the reverse proxy do not prevent SSH pull/push), but that does not looks like to be the intended behavior.

Originally created by @sloonz on GitHub (Mar 29, 2018). - Gitea version (or commit ref): 1.4.0 - Git version: 2.16.3 - Go version: 1.10 - Operating system: ArchLinux - Database (use `[x]`): - [ ] PostgreSQL - [x] MySQL - [ ] MSSQL - [ ] SQLite - Can you reproduce the bug at https://try.gitea.io: - [ ] Yes (provide example URL) - [ ] No - [x] Not relevant ## Description With the following configuration (actual domain redacted by example.com) in the `[server]` section: ``` PROTOCOL = unix HTTP_ADDR = /run/nginx/gitea.sock DOMAIN = git.example.com ROOT_URL = https://git.example.com/ LOCAL_ROOT_URL = %(PROTOCOL)s://%(HTTP_ADDR)s:%(HTTP_PORT)s/ ``` Trying to perform a git pull/push via SSH results in an error : ``` UpdatePublicKey: Post unix:///run/nginx/gitea.sockapi/internal/ssh/1/update: unsupported protocol scheme "unix" ``` Looks like a regression over https://github.com/go-gitea/gitea/issues/2232, which has been fixed months ago. Adding some good old `Printf` traces in the code, I can see that `req.SetTransport` is called in `newInternalRequest`, but the `Dial` function that is set up there is never called ; the error is encountered before then. Changing `LOCAL_ROOT_URL` to `http://%(DOMAIN)s/` fixes the issue : both the `req.SetTransport` and `Dial` functions are called, and the request is performed on the unix socket (no log in the reverse proxy that’s listening on https://git.example.com/, and adding `deny all` on the reverse proxy do not prevent SSH pull/push), but that does not looks like to be the intended behavior.

GiteaMirror added the type/question label 2025-11-02 04:08:52 -06:00

GiteaMirror closed this issue

2025-11-02 04:08:52 -06:00

GiteaMirror commented

2025-11-02 04:08:52 -06:00

@lafriks commented on GitHub (Mar 29, 2018):

When using unix sockets you should not set LOCAL_ROOT_URL in app.ini or need to set it to http://unix/

@lafriks commented on GitHub (Mar 29, 2018): When using unix sockets you should not set `LOCAL_ROOT_URL` in app.ini or need to set it to `http://unix/`

GiteaMirror commented

2025-11-02 04:08:52 -06:00

@sloonz commented on GitHub (Mar 30, 2018):

It works fine that way, but that is not what I understand from app.ini.sample:

; Local (DMZ) URL for Gitea workers (such as SSH update) accessing web service.
; In most cases you do not need to change the default value.
; Alter it only if your SSH server node is not the same as HTTP node.
LOCAL_ROOT_URL = %(PROTOCOL)s://%(HTTP_ADDR)s:%(HTTP_PORT)s/

@sloonz commented on GitHub (Mar 30, 2018): It works fine that way, but that is not what I understand from `app.ini.sample`: > ; Local (DMZ) URL for Gitea workers (such as SSH update) accessing web service. > ; In most cases you do not need to change the default value. > ; Alter it only if your SSH server node is not the same as HTTP node. > LOCAL_ROOT_URL = %(PROTOCOL)s://%(HTTP_ADDR)s:%(HTTP_PORT)s/

GiteaMirror commented

2025-11-02 04:08:53 -06:00

@lafriks commented on GitHub (Mar 30, 2018):

Yes this description is correct only if using http protocol for gitea listener, description needs to be updated if using other protocols

@lafriks commented on GitHub (Mar 30, 2018): Yes this description is correct only if using http protocol for gitea listener, description needs to be updated if using other protocols

GiteaMirror commented

2025-11-02 04:08:53 -06:00

@silverwind commented on GitHub (May 16, 2018):

When using unix sockets you should not set LOCAL_ROOT_URL in app.ini or need to set it to http://unix/

Couldn't this be done automatically when listening on a unix socket?

@silverwind commented on GitHub (May 16, 2018): > When using unix sockets you should not set LOCAL_ROOT_URL in app.ini or need to set it to http://unix/ Couldn't this be done automatically when listening on a unix socket?

GiteaMirror commented

2025-11-02 04:08:53 -06:00

@lafriks commented on GitHub (May 16, 2018):

It is if you have not set LOCAL_ROOT_URL to something in app.ini

@lafriks commented on GitHub (May 16, 2018): It is if you have not set `LOCAL_ROOT_URL` to something in app.ini

GiteaMirror commented

2025-11-02 04:08:53 -06:00

@silverwind commented on GitHub (May 16, 2018):

What I meant is that we could ignore LOCAL_ROOT_URL when PROTOCOL == 'unix', or am I missing something?

@silverwind commented on GitHub (May 16, 2018): What I meant is that we could ignore `LOCAL_ROOT_URL` when `PROTOCOL == 'unix'`, or am I missing something?

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#1664