[PR #2813] [MERGED] Fix comment API paths #16606

New Issue

GiteaMirror · 2025-11-02T12:14:31-06:00

GiteaMirror commented

2025-11-02 12:14:31 -06:00

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/2813
Author: @ethantkoenig
Created: 11/1/2017
Status: ✅ Merged
Merged: 11/20/2017
Merged by: @lunny

Base: master ← Head: fix/comment_api

📝 Commits (2)

96d1009 Fix comment API paths
492ff2f Merge branch 'master' into fix/comment_api

📊 Changes

4 files changed (+278 additions, -94 deletions)

View changed files

📝 integrations/api_comment_test.go (+4 -4)
📝 public/swagger.v1.json (+186 -85)
📝 routers/api/v1/api.go (+4 -3)
📝 routers/api/v1/repo/issue_comment.go (+84 -2)

📄 Description

Corrects the following comment API routes

PATCH /:owner/:repo/issues/:index/comments/:id -> PATCH /:owner/:repo/issues/comments/:id
DELETE /:owner/:repo/issues/:index/comments/:id -> DELETE /:owner/:repo/issues/comments/:id

The previous routes ignored the :index parameter, and were in conflict with the Github API. The previous route are marked as deprecated, but have not been removed.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/2813 **Author:** [@ethantkoenig](https://github.com/ethantkoenig) **Created:** 11/1/2017 **Status:** ✅ Merged **Merged:** 11/20/2017 **Merged by:** [@lunny](https://github.com/lunny) **Base:** `master` ← **Head:** `fix/comment_api` --- ### 📝 Commits (2) - [`96d1009`](https://github.com/go-gitea/gitea/commit/96d1009077901fdcf8cd41b028406b391ec52a37) Fix comment API paths - [`492ff2f`](https://github.com/go-gitea/gitea/commit/492ff2fa9474e1dbed5d286f9734447bf8a1d14b) Merge branch 'master' into fix/comment_api ### 📊 Changes **4 files changed** (+278 additions, -94 deletions) <details> <summary>View changed files</summary> 📝 `integrations/api_comment_test.go` (+4 -4) 📝 `public/swagger.v1.json` (+186 -85) 📝 `routers/api/v1/api.go` (+4 -3) 📝 `routers/api/v1/repo/issue_comment.go` (+84 -2) </details> ### 📄 Description Corrects the following comment API routes - `PATCH /:owner/:repo/issues/:index/comments/:id` -> `PATCH /:owner/:repo/issues/comments/:id` - `DELETE /:owner/:repo/issues/:index/comments/:id` -> `DELETE /:owner/:repo/issues/comments/:id` The previous routes ignored the `:index` parameter, and were in conflict with [the Github API](https://developer.github.com/v3/issues/comments/). The previous route are marked as deprecated, but have not been removed. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-02 12:14:31 -06:00

GiteaMirror closed this issue

2025-11-02 12:14:31 -06:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#16606