[PR #2779] [MERGED] Sync MaxGitDiffLineCharacters with conf/app.ini #16587

New Issue

GiteaMirror · 2025-11-02T12:14:05-06:00

GiteaMirror commented

2025-11-02 12:14:05 -06:00

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/2779
Author: @michaelkuhn
Created: 10/25/2017
Status: ✅ Merged
Merged: 10/25/2017
Merged by: @lunny

Base: master ← Head: maxgitdifflinecharacters

📝 Commits (1)

b7db6b8 Sync MaxGitDiffLineCharacters with conf/app.ini

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 modules/setting/setting.go (+1 -1)

📄 Description

MAX_GIT_DIFF_LINE_CHARACTERS was updated in #1845 but the corresponding default value of MaxGitDiffLineCharacters was not changed. This can lead to inconsistencies.

Specifically, with my bindata build, Gitea used the default of 500 instead of 5000 because MAX_GIT_DIFF_LINE_CHARACTERS is not set in my custom/conf/app.ini.

I found the bug with version 1.2 but it should also apply to master.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/2779 **Author:** [@michaelkuhn](https://github.com/michaelkuhn) **Created:** 10/25/2017 **Status:** ✅ Merged **Merged:** 10/25/2017 **Merged by:** [@lunny](https://github.com/lunny) **Base:** `master` ← **Head:** `maxgitdifflinecharacters` --- ### 📝 Commits (1) - [`b7db6b8`](https://github.com/go-gitea/gitea/commit/b7db6b870b987e8dc861e349fdfc659301e0e900) Sync MaxGitDiffLineCharacters with conf/app.ini ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `modules/setting/setting.go` (+1 -1) </details> ### 📄 Description `MAX_GIT_DIFF_LINE_CHARACTERS` was updated in #1845 but the corresponding default value of `MaxGitDiffLineCharacters` was not changed. This can lead to inconsistencies. Specifically, with my `bindata` build, Gitea used the default of 500 instead of 5000 because `MAX_GIT_DIFF_LINE_CHARACTERS` is not set in my `custom/conf/app.ini`. I found the bug with version 1.2 but it should also apply to master. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-02 12:14:05 -06:00

GiteaMirror closed this issue

2025-11-02 12:14:05 -06:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#16587