github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-12 10:39:38 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

Compare button on upstream repo leads to 404 #1655

New Issue
Closed
opened 2025-11-02 04:08:34 -06:00 by GiteaMirror · 17 comments
GiteaMirror commented 2025-11-02 04:08:34 -06:00
Owner
Copy Link

Originally created by @mxmehl on GitHub (Mar 27, 2018).

  • Gitea version (or commit ref): 1.4.0
  • Git version: 2.1.4
  • Operating system: Debian 8
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
    • Not relevant: does not work

Description

Scenario: I, user joe, forked repository repo of another user called upstream.

Now, if I am on joe/repo and click on the green compare button, everything works as expected and I see the "Compare Changes" window. However, this doesn't work on upstream/repo, there I see a 404 error.

I noted that the 404 does not appear if I'm owner of the upstream repository's organisation.

The links of the button look like this:

https://git.example.org/upstream/repo/compare/master...joe:master from forked repo -> works
https://git.example.org/upstream/repo/compare/master...upstream:master from upstream repo -> doesn't work

I cannot check how the links looked like in 1.3, but I was told by a user on my Gitea instance that it worked before.

Originally created by @mxmehl on GitHub (Mar 27, 2018). - Gitea version (or commit ref): 1.4.0 - Git version: 2.1.4 - Operating system: Debian 8 - Database (use `[x]`): - [ ] PostgreSQL - [x] MySQL - [ ] MSSQL - [ ] SQLite - Can you reproduce the bug at https://try.gitea.io: - [ ] Yes (provide example URL) - [ ] No - [x] Not relevant: does not work ## Description Scenario: I, user `joe`, forked repository `repo` of another user called `upstream`. Now, if I am on joe/repo and click on the green compare button, everything works as expected and I see the "Compare Changes" window. However, this doesn't work on upstream/repo, there I see a 404 error. I noted that the 404 does not appear if I'm owner of the upstream repository's organisation. The links of the button look like this: `https://git.example.org/upstream/repo/compare/master...joe:master` from forked repo -> works `https://git.example.org/upstream/repo/compare/master...upstream:master` from upstream repo -> doesn't work I cannot check how the links looked like in 1.3, but I was told by a user on my Gitea instance that it worked before.
GiteaMirror added the issue/confirmedtopic/uitype/bug labels 2025-11-02 04:08:34 -06:00
GiteaMirror commented 2025-11-02 04:08:35 -06:00
Author
Owner
Copy Link

@ghost commented on GitHub (Mar 27, 2018):

I cannot check how the links looked like in 1.3, but I was told by a user on my Gitea instance that it worked before.

I can confirm that.

@ghost commented on GitHub (Mar 27, 2018): > I cannot check how the links looked like in 1.3, but I was told by a user on my Gitea instance that it worked before. I can confirm that.
GiteaMirror commented 2025-11-02 04:08:35 -06:00
Author
Owner
Copy Link

@lafriks commented on GitHub (Mar 27, 2018):

Does link https://git.example.org/upstream/repo/compare/master...master work?

@lafriks commented on GitHub (Mar 27, 2018): Does link `https://git.example.org/upstream/repo/compare/master...master` work?
GiteaMirror commented 2025-11-02 04:08:35 -06:00
Author
Owner
Copy Link

@mxmehl commented on GitHub (Mar 27, 2018):

Does link https://git.example.org/upstream/repo/compare/master...master work?

No, this also generates an 404. As repo or organisation owner it seems to work though.

@mxmehl commented on GitHub (Mar 27, 2018): > Does link https://git.example.org/upstream/repo/compare/master...master work? No, this also generates an 404. As repo or organisation owner it seems to work though.
GiteaMirror commented 2025-11-02 04:08:35 -06:00
Author
Owner
Copy Link

@lafriks commented on GitHub (Mar 28, 2018):

What rights does user joe does for upstream repo? Is it private or public?

@lafriks commented on GitHub (Mar 28, 2018): What rights does user `joe` does for upstream repo? Is it private or public?
GiteaMirror commented 2025-11-02 04:08:35 -06:00
Author
Owner
Copy Link

@ghost commented on GitHub (Mar 29, 2018):

Please note that the 'New Pull Request' button in the Pull Requests tab works perfectly and generates this link:

https://git.example.org/upstream/repo/compare/master...joe:master
@ghost commented on GitHub (Mar 29, 2018): Please note that the 'New Pull Request' button in the Pull Requests tab works perfectly and generates this link: ``` https://git.example.org/upstream/repo/compare/master...joe:master ```
GiteaMirror commented 2025-11-02 04:08:36 -06:00
Author
Owner
Copy Link

@mxmehl commented on GitHub (Mar 29, 2018):

What rights does user joe does for upstream repo? Is it private or public?

No specific permissions (i.e. no organisation or team member, or collaborator). The repo is public.

@mxmehl commented on GitHub (Mar 29, 2018): > What rights does user `joe` does for upstream repo? Is it private or public? No specific permissions (i.e. no organisation or team member, or collaborator). The repo is public.
GiteaMirror commented 2025-11-02 04:08:36 -06:00
Author
Owner
Copy Link

@Infern1 commented on GitHub (Apr 19, 2018):

Seeing the same problem

When clicking pull request this url is generated

http://git.server.com/git/APCS-WEB/WEB_MasterLmpc/compare/master...my_username:master

and returns a 404
If I change the url to
http://git.server.com/git/APCS-WEB/WEB_MasterLmpc/compare/master...develop

it works

Isn't this same error, fixed:
afab38b0d7
?

@Infern1 commented on GitHub (Apr 19, 2018): Seeing the same problem When clicking pull request this url is generated `http://git.server.com/git/APCS-WEB/WEB_MasterLmpc/compare/master...my_username:master` and returns a 404 If I change the url to `http://git.server.com/git/APCS-WEB/WEB_MasterLmpc/compare/master...develop` it works Isn't this same error, fixed: https://github.com/gogits/gogs/commit/afab38b0d74c65e1deb4348a411cd3a13a641b74 ?
GiteaMirror commented 2025-11-02 04:08:36 -06:00
Author
Owner
Copy Link

@stale[bot] commented on GitHub (Jan 28, 2019):

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale[bot] commented on GitHub (Jan 28, 2019): This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.
GiteaMirror commented 2025-11-02 04:08:36 -06:00
Author
Owner
Copy Link

@adelowo commented on GitHub (Jan 28, 2019):

Sent a PR for this already

@adelowo commented on GitHub (Jan 28, 2019): Sent a PR for this already
GiteaMirror commented 2025-11-02 04:08:37 -06:00
Author
Owner
Copy Link

@notgood commented on GitHub (Feb 1, 2019):

Broken for me since today upgrade to 1.7.1.

My scenario: repo owned by organization, no forks, green compare button generates link /orgname/reponame/compare/master...MyUsername:master, which is failing horribly with 404.
Going through Pull Requests->New Pull Request generates /orgname/reponame/compare/master...master, working as expected.

@notgood commented on GitHub (Feb 1, 2019): Broken for me since today upgrade to 1.7.1. My scenario: repo owned by organization, no forks, green compare button generates link /orgname/reponame/compare/master...MyUsername:master, which is failing horribly with 404. Going through Pull Requests->New Pull Request generates /orgname/reponame/compare/master...master, working as expected.
GiteaMirror commented 2025-11-02 04:08:37 -06:00
Author
Owner
Copy Link

@zeripath commented on GitHub (Feb 1, 2019):

Argh. We need better UI tests.

@adelowo do you think we should just revert your patch.

@zeripath commented on GitHub (Feb 1, 2019): Argh. We need better UI tests. @adelowo do you think we should just revert your patch.
GiteaMirror commented 2025-11-02 04:08:37 -06:00
Author
Owner
Copy Link

@adelowo commented on GitHub (Feb 1, 2019):

@zeripath Argh, yes, my bad, I didn't test all scenarios

I will look at this again during the weekend but it should be reverted in the main time

@adelowo commented on GitHub (Feb 1, 2019): @zeripath Argh, yes, my bad, I didn't test all scenarios I will look at this again during the weekend but it should be reverted in the main time
GiteaMirror commented 2025-11-02 04:08:37 -06:00
Author
Owner
Copy Link

@adelowo commented on GitHub (Feb 1, 2019):

See https://github.com/go-gitea/gitea/issues/5924#issuecomment-459868372

@adelowo commented on GitHub (Feb 1, 2019): See https://github.com/go-gitea/gitea/issues/5924#issuecomment-459868372
GiteaMirror commented 2025-11-02 04:08:38 -06:00
Author
Owner
Copy Link

@dmolineus commented on GitHub (Feb 22, 2019):

Another thing, I see here. The given url does not url encode the branch name which leads to another 404 even if user prefix wouldn't be there.

  1. Expected link customer-projects/***-photo/compare/master...hotfix%2Fphp-7-compatiblity
  2. Acutal link customer-projects/***-photo/compare/master...username:hotfix/php-7-compatiblity
@dmolineus commented on GitHub (Feb 22, 2019): Another thing, I see here. The given url does not url encode the branch name which leads to another 404 even if user prefix wouldn't be there. 1. Expected link `customer-projects/***-photo/compare/master...hotfix%2Fphp-7-compatiblity` 2. Acutal link `customer-projects/***-photo/compare/master...username:hotfix/php-7-compatiblity`
GiteaMirror commented 2025-11-02 04:08:38 -06:00
Author
Owner
Copy Link

@lunny commented on GitHub (Feb 23, 2019):

@dmolineus which version are you using? I think this has been resolved by #6098

@lunny commented on GitHub (Feb 23, 2019): @dmolineus which version are you using? I think this has been resolved by #6098
GiteaMirror commented 2025-11-02 04:08:38 -06:00
Author
Owner
Copy Link

@dmolineus commented on GitHub (Feb 25, 2019):

@lunny Im using 1.7.2 built with go1.11.5. The mentioned PR isn't released yet, so maybe it's resolved. Thanks for pointing it out.

@dmolineus commented on GitHub (Feb 25, 2019): @lunny Im using `1.7.2 built with go1.11.5`. The mentioned PR isn't released yet, so maybe it's resolved. Thanks for pointing it out.
GiteaMirror commented 2025-11-02 04:08:38 -06:00
Author
Owner
Copy Link

@mrsdizzie commented on GitHub (Sep 7, 2020):

Should be resolved from linked PRs

@mrsdizzie commented on GitHub (Sep 7, 2020): Should be resolved from linked PRs
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label issue/confirmed topic/ui type/bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#1655
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?