Refactor createComment for Issue assignees #1652

Closed
opened 2025-11-02 04:08:29 -06:00 by GiteaMirror · 1 comment
Owner

Originally created by @kolaente on GitHub (Mar 25, 2018).

IMHO, the structure to create a comment when assigning or un-assigning someone to an issue is terrible, it is not clear at who (un)assigned who. I think each of these "events" (assigned someone, assigned itself, unassigned someone, unassigned itself should be a seperate comment type instead of saving an extra pararmeter for every comment for this.

(I'll do this some time, probably once #3705 is merged, sorry if I wasn't very clear with what I mean)

Originally created by @kolaente on GitHub (Mar 25, 2018). IMHO, the structure to create a comment when assigning or un-assigning someone to an issue is terrible, it is not clear at who (un)assigned who. I think each of these "events" (`assigned someone`, `assigned itself`, `unassigned someone`, `unassigned itself` should be a seperate comment type instead of saving an extra pararmeter for _every comment_ for this. (I'll do this some time, probably once #3705 is merged, sorry if I wasn't very clear with what I mean)
GiteaMirror added the type/proposaltype/refactoring labels 2025-11-02 04:08:29 -06:00
Author
Owner

@delvh commented on GitHub (Apr 29, 2023):

I think that's already implemented since a long time.

@delvh commented on GitHub (Apr 29, 2023): I think that's already implemented since a long time.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#1652