github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-09 04:25:18 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

[PR #2611] [MERGED] Fix doubled issue tab introduced in migration v16 #16505

New Issue
Closed
opened 2025-11-02 12:12:12 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-02 12:12:12 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/2611
Author: @daviian
Created: 9/26/2017
Status: ✅ Merged
Merged: 9/28/2017
Merged by: @lafriks

Base: master ← Head: bugfix/doubled-issues-unit-type

📝 Commits (5)

  • 160f766 fix duplicate issue tab as UnitTypeIssue and UnitTypeExternalTracker are existing at the same time
  • 9f6c9b8 remove duplcate wiki unit types
  • 1329ebe fix lint error
  • 99d07b1 remove unnecessary repository table join
  • 4c0da6c Merge branch 'master' into bugfix/doubled-issues-unit-type

📊 Changes

2 files changed (+71 additions, -0 deletions)

View changed files

📝 models/migrations/migrations.go (+2 -0)
➕ models/migrations/v44.go (+69 -0)

📄 Description

Migration v16 creates UnitTypeIssue and UnitTypeExternalTracker for each repository with enabled external issue tracker as repo.EnableIssues is true even for external tracker.

And because both Unit Types exist the issue tab is shown twice.

The same behaviour is happening to UnitTypeWiki and UnitTypeExternalWiki, but because the tab is not changed in view it has no visual impact.

PR fixes both mistakes and removes UnitTypeIssue for repositories with UniTypeExternalTracker and removes UnitTypeWiki for repositories with UnitTypeExternalWiki.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/2611 **Author:** [@daviian](https://github.com/daviian) **Created:** 9/26/2017 **Status:** ✅ Merged **Merged:** 9/28/2017 **Merged by:** [@lafriks](https://github.com/lafriks) **Base:** `master` ← **Head:** `bugfix/doubled-issues-unit-type` --- ### 📝 Commits (5) - [`160f766`](https://github.com/go-gitea/gitea/commit/160f766bce688f5b34d1fc44cbb80415423976d0) fix duplicate issue tab as UnitTypeIssue and UnitTypeExternalTracker are existing at the same time - [`9f6c9b8`](https://github.com/go-gitea/gitea/commit/9f6c9b8a4322d3897bcac8f6f34c0c2a284b41b8) remove duplcate wiki unit types - [`1329ebe`](https://github.com/go-gitea/gitea/commit/1329ebeb3866807ad504952fc9725e77122bde09) fix lint error - [`99d07b1`](https://github.com/go-gitea/gitea/commit/99d07b167793365a097e072fa928067a2419491a) remove unnecessary repository table join - [`4c0da6c`](https://github.com/go-gitea/gitea/commit/4c0da6cb373f04174071b7873eaa4f3b0e433060) Merge branch 'master' into bugfix/doubled-issues-unit-type ### 📊 Changes **2 files changed** (+71 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `models/migrations/migrations.go` (+2 -0) ➕ `models/migrations/v44.go` (+69 -0) </details> ### 📄 Description Migration v16 creates UnitTypeIssue and UnitTypeExternalTracker for each repository with enabled external issue tracker as repo.EnableIssues is true even for external tracker. And because both Unit Types exist the issue tab is shown twice. The same behaviour is happening to UnitTypeWiki and UnitTypeExternalWiki, but because the tab is not changed in view it has no visual impact. PR fixes both mistakes and removes UnitTypeIssue for repositories with UniTypeExternalTracker and removes UnitTypeWiki for repositories with UnitTypeExternalWiki. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-02 12:12:12 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#16505
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?