github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-16 13:13:23 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

[PR #2603] [CLOSED] add sorting to database query of repo_units #16500

New Issue
Closed
opened 2025-11-02 12:12:04 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-02 12:12:04 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/2603
Author: @daviian
Created: 9/25/2017
Status: ❌ Closed

Base: master ← Head: bugfix/unit-type-sort

📝 Commits (5)

  • e86ed4f sort repo units by type to prevent wrong redirect
  • 80d294a change fixture to create a scenario with wrong sorting of repo_units
  • 4ad6a57 change sorting to index instead of type
  • f556e19 Merge branch 'master' into bugfix/unit-type-sort
  • 0fc1ad6 Merge branch 'master' into bugfix/unit-type-sort

📊 Changes

2 files changed (+14 additions, -14 deletions)

View changed files

📝 models/fixtures/repo_unit.yml (+12 -12)
📝 models/repo_unit.go (+2 -2)

📄 Description

If sorting is wrong and UnitTypeCode is not the first one, a user can't visit to the Code Tab even with required permissions.

Furthermore fixes wrong redirect to leftmost accessible tab in repo view.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/2603 **Author:** [@daviian](https://github.com/daviian) **Created:** 9/25/2017 **Status:** ❌ Closed **Base:** `master` ← **Head:** `bugfix/unit-type-sort` --- ### 📝 Commits (5) - [`e86ed4f`](https://github.com/go-gitea/gitea/commit/e86ed4f6debdc40c9496f67578f95a6edb8d803f) sort repo units by type to prevent wrong redirect - [`80d294a`](https://github.com/go-gitea/gitea/commit/80d294a88d8cf7e68d71e8192c41cda373b026c5) change fixture to create a scenario with wrong sorting of repo_units - [`4ad6a57`](https://github.com/go-gitea/gitea/commit/4ad6a570917f13a97d2d8a5057d10236f056df0b) change sorting to index instead of type - [`f556e19`](https://github.com/go-gitea/gitea/commit/f556e19aca5bafb830255f9b4369a6a05279ccb7) Merge branch 'master' into bugfix/unit-type-sort - [`0fc1ad6`](https://github.com/go-gitea/gitea/commit/0fc1ad6d4c24afaae2a18ace40d94e2894e6c14f) Merge branch 'master' into bugfix/unit-type-sort ### 📊 Changes **2 files changed** (+14 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `models/fixtures/repo_unit.yml` (+12 -12) 📝 `models/repo_unit.go` (+2 -2) </details> ### 📄 Description If sorting is wrong and UnitTypeCode is not the first one, a user can't visit to the `Code` Tab even with required permissions. Furthermore fixes wrong redirect to leftmost accessible tab in repo view. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-02 12:12:04 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#16500
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?