[PR #2556] [MERGED] Fix adding branch as protected to not allow pushing to it #16464

New Issue

GiteaMirror · 2025-11-02T12:11:15-06:00

GiteaMirror commented

2025-11-02 12:11:15 -06:00

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/2556
Author: @lafriks
Created: 9/20/2017
Status: ✅ Merged
Merged: 9/20/2017
Merged by: @lafriks

Base: release/v1.2 ← Head: fix_protected_branches

📝 Commits (4)

9026bc3 Fix adding branch as protected to not allow pushing to it
918f0d4 Fix can_push value to false in protected_branch (#2560)
9860805 Merge branch 'release/v1.2' into fix_protected_branches
3e2a1a3 Fix integration test

📊 Changes

7 files changed (+34 additions, -16 deletions)

View changed files

📝 cmd/hook.go (+6 -8)
📝 integrations/editor_test.go (+1 -1)
📝 models/branches.go (+4 -4)
📝 models/migrations/migrations.go (+2 -0)
➕ models/migrations/v43.go (+18 -0)
📝 public/js/index.js (+2 -2)
📝 routers/repo/setting.go (+1 -1)

📄 Description

Fixes #2517

This PR targets 1.2 branch as bug is present only in it. In master branch it works fine as @lunny did rewrite protected branch UI & functionality with whitelist support

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/2556 **Author:** [@lafriks](https://github.com/lafriks) **Created:** 9/20/2017 **Status:** ✅ Merged **Merged:** 9/20/2017 **Merged by:** [@lafriks](https://github.com/lafriks) **Base:** `release/v1.2` ← **Head:** `fix_protected_branches` --- ### 📝 Commits (4) - [`9026bc3`](https://github.com/go-gitea/gitea/commit/9026bc3af5baf7f36c3df4f7919c855bbcbb7e49) Fix adding branch as protected to not allow pushing to it - [`918f0d4`](https://github.com/go-gitea/gitea/commit/918f0d4f204dbeeca601c2b166bc7aa09cbcdabe) Fix can_push value to false in protected_branch (#2560) - [`9860805`](https://github.com/go-gitea/gitea/commit/9860805ede736ba58c92d609947b84300016de90) Merge branch 'release/v1.2' into fix_protected_branches - [`3e2a1a3`](https://github.com/go-gitea/gitea/commit/3e2a1a33d862acc9d9ac0d41914768b1f74033d0) Fix integration test ### 📊 Changes **7 files changed** (+34 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `cmd/hook.go` (+6 -8) 📝 `integrations/editor_test.go` (+1 -1) 📝 `models/branches.go` (+4 -4) 📝 `models/migrations/migrations.go` (+2 -0) ➕ `models/migrations/v43.go` (+18 -0) 📝 `public/js/index.js` (+2 -2) 📝 `routers/repo/setting.go` (+1 -1) </details> ### 📄 Description Fixes #2517 This PR targets 1.2 branch as bug is present only in it. In master branch it works fine as @lunny did rewrite protected branch UI & functionality with whitelist support --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-02 12:11:15 -06:00

GiteaMirror closed this issue

2025-11-02 12:11:15 -06:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#16464