[PR #2546] [MERGED] Always run fmt check in CI #16456

Closed
opened 2025-11-02 12:11:05 -06:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/2546
Author: @ethantkoenig
Created: 9/19/2017
Status: Merged
Merged: 9/21/2017
Merged by: @lunny

Base: masterHead: ci/run_fmt_check


📝 Commits (1)

  • e635c3b Always run fmt check in CI

📊 Changes

2 files changed (+2 additions, -1 deletions)

View changed files

📝 .drone.yml (+1 -0)
📝 Makefile (+1 -1)

📄 Description

Previously, make fmt-check would only run as a dependency of make test, which only runs on tag events. See also #2544.

I also removed fmt-check as a dependency of test, because I don't see why the two should be related. Let me know if I'm missing something.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/2546 **Author:** [@ethantkoenig](https://github.com/ethantkoenig) **Created:** 9/19/2017 **Status:** ✅ Merged **Merged:** 9/21/2017 **Merged by:** [@lunny](https://github.com/lunny) **Base:** `master` ← **Head:** `ci/run_fmt_check` --- ### 📝 Commits (1) - [`e635c3b`](https://github.com/go-gitea/gitea/commit/e635c3b298c91b03d963c74097d30e09f0bc9238) Always run fmt check in CI ### 📊 Changes **2 files changed** (+2 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `.drone.yml` (+1 -0) 📝 `Makefile` (+1 -1) </details> ### 📄 Description Previously, `make fmt-check` would only run as a dependency of `make test`, which only runs on tag events. See also #2544. I also removed `fmt-check` as a dependency of `test`, because I don't see why the two should be related. Let me know if I'm missing something. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-02 12:11:05 -06:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#16456