github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-12 02:24:21 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

[PR #2530] [MERGED] Complete push webhooks #16446

New Issue
Closed
opened 2025-11-02 12:10:50 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-02 12:10:50 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/2530
Author: @daviian
Created: 9/17/2017
Status: ✅ Merged
Merged: 9/21/2017
Merged by: @lafriks

Base: master ← Head: feature/complete-push-webhooks

📝 Commits (7)

  • 0bd387e implemented missing 'delete' push webhooks
  • 85cb006 add CommitRepoAction tests for tag/branch creation/deletion
  • 8df0167 fixed error where push webhook not called if is new branch or tag
  • c64ea0c moved prepare unit test environment into separate method to be used across unit tests
  • 8d2518d add missing if clause in pushUpdate
  • b6c13ab Merge branch 'master' into feature/complete-push-webhooks
  • 477ce63 Merge branch 'master' into feature/complete-push-webhooks

📊 Changes

8 files changed (+197 additions, -102 deletions)

View changed files

➕ integrations/gitea-repositories-meta/user2/repo1.git/refs/tags/v1.1 (+1 -0)
📝 models/action.go (+41 -16)
📝 models/action_test.go (+103 -41)
📝 models/unit_tests.go (+10 -0)
📝 models/update.go (+33 -44)
📝 modules/templates/helper.go (+1 -1)
📝 options/locale/locale_en-US.ini (+2 -0)
📝 templates/user/dashboard/feeds.tmpl (+6 -0)

📄 Description

Targets #2105 and thus #2418

Description:
PR enables push webhooks for branch and tag deletion to catchup with github's push webhook implemenation.
Furthermore it adds to new actions - ActionDeleteTag and ActionDeleteBranch.
Includes unit tests for CommitRepoAction function.

Needs to be rebased after #2459 is merged.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/2530 **Author:** [@daviian](https://github.com/daviian) **Created:** 9/17/2017 **Status:** ✅ Merged **Merged:** 9/21/2017 **Merged by:** [@lafriks](https://github.com/lafriks) **Base:** `master` ← **Head:** `feature/complete-push-webhooks` --- ### 📝 Commits (7) - [`0bd387e`](https://github.com/go-gitea/gitea/commit/0bd387e36a891370486845f7008448799cc233ac) implemented missing 'delete' push webhooks - [`85cb006`](https://github.com/go-gitea/gitea/commit/85cb006e8308e8564a8eb9a18b9cee74de029e2f) add CommitRepoAction tests for tag/branch creation/deletion - [`8df0167`](https://github.com/go-gitea/gitea/commit/8df0167581959db6af2a8ad5274b226e8224db55) fixed error where push webhook not called if is new branch or tag - [`c64ea0c`](https://github.com/go-gitea/gitea/commit/c64ea0cf48ab12eed298408baf09d7d5d362f513) moved prepare unit test environment into separate method to be used across unit tests - [`8d2518d`](https://github.com/go-gitea/gitea/commit/8d2518d62ff4f88ec35bc29833a7f2cfbd789ff4) add missing if clause in pushUpdate - [`b6c13ab`](https://github.com/go-gitea/gitea/commit/b6c13ab3da576fc52c5deb58e3929f2f8bb52eb7) Merge branch 'master' into feature/complete-push-webhooks - [`477ce63`](https://github.com/go-gitea/gitea/commit/477ce6310500c666265d7f2d3578a451e7db72eb) Merge branch 'master' into feature/complete-push-webhooks ### 📊 Changes **8 files changed** (+197 additions, -102 deletions) <details> <summary>View changed files</summary> ➕ `integrations/gitea-repositories-meta/user2/repo1.git/refs/tags/v1.1` (+1 -0) 📝 `models/action.go` (+41 -16) 📝 `models/action_test.go` (+103 -41) 📝 `models/unit_tests.go` (+10 -0) 📝 `models/update.go` (+33 -44) 📝 `modules/templates/helper.go` (+1 -1) 📝 `options/locale/locale_en-US.ini` (+2 -0) 📝 `templates/user/dashboard/feeds.tmpl` (+6 -0) </details> ### 📄 Description Targets #2105 and thus #2418 Description: PR enables push webhooks for branch and tag deletion to catchup with github's push webhook implemenation. Furthermore it adds to new actions - ActionDeleteTag and ActionDeleteBranch. Includes unit tests for `CommitRepoAction` function. Needs to be rebased after #2459 is merged. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-02 12:10:50 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#16446
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?