[PR #2519] [CLOSED] Add commit status on repo and user pull request lists #16441

Closed
opened 2025-11-02 12:10:43 -06:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/2519
Author: @lunny
Created: 9/15/2017
Status: Closed

Base: masterHead: lunny/add_commit_status_pr


📝 Commits (10+)

  • deb88a4 add commit status on repo and user pull request lists
  • f3a43b4 use GetLatestCommitStatuses instead GetLatestCommitStatus to reduce db operations
  • efe0220 fix GetLatestCommitStatuses
  • 3e0a87c add tests for pulls commit status and some fixes
  • 4824f72 refactor GetLatestCommitStatuses and some other improvements
  • 15e49d6 remove unused variable on template
  • 8f54636 remove removed column on tests fixtures
  • 53c4f6f fix tests
  • bc4470a fix tests
  • b2ba574 improve GetIssuesLatestCommitStatuses

📊 Changes

10 files changed (+308 additions, -24 deletions)

View changed files

📝 integrations/editor_test.go (+13 -0)
integrations/repo_pull_status_test.go (+128 -0)
📝 models/fixtures/repo_unit.yml (+36 -1)
📝 models/pull.go (+6 -6)
📝 models/status.go (+72 -0)
📝 routers/repo/issue.go (+17 -1)
📝 routers/user/home.go (+14 -0)
📝 templates/repo/commit_status.tmpl (+16 -14)
📝 templates/repo/issue/list.tmpl (+3 -1)
📝 templates/user/dashboard/issues.tmpl (+3 -1)

📄 Description

And something confusing me is should I use issue.PullRequest.MergeBase as the last commit of a pull request? Anyway, see the screenshots below:

-1
-2


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/2519 **Author:** [@lunny](https://github.com/lunny) **Created:** 9/15/2017 **Status:** ❌ Closed **Base:** `master` ← **Head:** `lunny/add_commit_status_pr` --- ### 📝 Commits (10+) - [`deb88a4`](https://github.com/go-gitea/gitea/commit/deb88a440d2a68ab85cf83da8132c2b1cecb7665) add commit status on repo and user pull request lists - [`f3a43b4`](https://github.com/go-gitea/gitea/commit/f3a43b41c6a936f8ec14e44a4dd2fb0bbf1133eb) use GetLatestCommitStatuses instead GetLatestCommitStatus to reduce db operations - [`efe0220`](https://github.com/go-gitea/gitea/commit/efe022016930d2ff0bd0f227352ea5158519216b) fix GetLatestCommitStatuses - [`3e0a87c`](https://github.com/go-gitea/gitea/commit/3e0a87c044b60acfe9bb01c85ef0210f5d7e6822) add tests for pulls commit status and some fixes - [`4824f72`](https://github.com/go-gitea/gitea/commit/4824f7207301d329f058d77ccdfe278384344f93) refactor GetLatestCommitStatuses and some other improvements - [`15e49d6`](https://github.com/go-gitea/gitea/commit/15e49d6211831e3bde58f8f52e6b12f013e97bab) remove unused variable on template - [`8f54636`](https://github.com/go-gitea/gitea/commit/8f5463630c4577697cd204befbfe654e79b30657) remove removed column on tests fixtures - [`53c4f6f`](https://github.com/go-gitea/gitea/commit/53c4f6f30e326be400d5a5eaa1fbe6d047cb9b2d) fix tests - [`bc4470a`](https://github.com/go-gitea/gitea/commit/bc4470a9b427e07012cef583efda58cd9afd1c9b) fix tests - [`b2ba574`](https://github.com/go-gitea/gitea/commit/b2ba5742dbbb1e1769e9d03718910b26cb7ab864) improve GetIssuesLatestCommitStatuses ### 📊 Changes **10 files changed** (+308 additions, -24 deletions) <details> <summary>View changed files</summary> 📝 `integrations/editor_test.go` (+13 -0) ➕ `integrations/repo_pull_status_test.go` (+128 -0) 📝 `models/fixtures/repo_unit.yml` (+36 -1) 📝 `models/pull.go` (+6 -6) 📝 `models/status.go` (+72 -0) 📝 `routers/repo/issue.go` (+17 -1) 📝 `routers/user/home.go` (+14 -0) 📝 `templates/repo/commit_status.tmpl` (+16 -14) 📝 `templates/repo/issue/list.tmpl` (+3 -1) 📝 `templates/user/dashboard/issues.tmpl` (+3 -1) </details> ### 📄 Description And something confusing me is should I use `issue.PullRequest.MergeBase` as the last commit of a pull request? Anyway, see the screenshots below: ![-1](https://user-images.githubusercontent.com/81045/30474451-4e57f690-9a36-11e7-8f3d-c942398fe43d.png) ![-2](https://user-images.githubusercontent.com/81045/30474454-532a30f2-9a36-11e7-8099-3232fa93cc9d.png) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-02 12:10:43 -06:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#16441