[PR #2337] [MERGED] Use standard lessc and minify CSS using Node.js #16350

Closed
opened 2025-11-02 12:08:34 -06:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/2337
Author: @silverwind
Created: 8/19/2017
Status: Merged
Merged: 9/21/2017
Merged by: @lunny

Base: masterHead: node-css-build


📝 Commits (5)

  • 6641d72 Use standard lessc and minify CSS using Node.js
  • 5fbbea2 install node, npm and modules on drone
  • 0d42d7b .PHONY
  • ea925d8 use 'minify' to minify CSS
  • c00f746 Merge branch 'master' into node-css-build

📊 Changes

6 files changed (+25 additions, -3139 deletions)

View changed files

📝 .drone.yml (+2 -0)
📝 .gitignore (+1 -0)
📝 CONTRIBUTING.md (+10 -0)
📝 Makefile (+5 -8)
package.json (+6 -0)
📝 public/css/index.css (+1 -3131)

📄 Description

This changes the previous nonstandard lessc to the official one and
enables CSS minification via the clean-css module.

To build CSS, Node.js is required along with a npm install to get the
tools installed locally in node_modules so there is no dependency on
binaries in PATH. Benefits include:

  • Allows one to have a standard lessc in PATH.
  • Can now use command line switches on lessc.
  • Minified CSS brings faster page load times and also has the benefit
    of discouraging contributors from editing CSS directly.

To build CSS, Node.js is required along with a npm install to get the
tools installed locally based on the information in package.json.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/2337 **Author:** [@silverwind](https://github.com/silverwind) **Created:** 8/19/2017 **Status:** ✅ Merged **Merged:** 9/21/2017 **Merged by:** [@lunny](https://github.com/lunny) **Base:** `master` ← **Head:** `node-css-build` --- ### 📝 Commits (5) - [`6641d72`](https://github.com/go-gitea/gitea/commit/6641d7226e796ea3426ee987ba1cd98c06055508) Use standard lessc and minify CSS using Node.js - [`5fbbea2`](https://github.com/go-gitea/gitea/commit/5fbbea286c06df8d8d531353a335d1949af65039) install node, npm and modules on drone - [`0d42d7b`](https://github.com/go-gitea/gitea/commit/0d42d7b0ae0d43c4776c30a820ecdb463d32cee8) .PHONY - [`ea925d8`](https://github.com/go-gitea/gitea/commit/ea925d8c0b45eb69aa255d5ccfb67114d8726204) use 'minify' to minify CSS - [`c00f746`](https://github.com/go-gitea/gitea/commit/c00f746b217ef9cd057a2b379789dff54e3f3109) Merge branch 'master' into node-css-build ### 📊 Changes **6 files changed** (+25 additions, -3139 deletions) <details> <summary>View changed files</summary> 📝 `.drone.yml` (+2 -0) 📝 `.gitignore` (+1 -0) 📝 `CONTRIBUTING.md` (+10 -0) 📝 `Makefile` (+5 -8) ➕ `package.json` (+6 -0) 📝 `public/css/index.css` (+1 -3131) </details> ### 📄 Description This changes the previous nonstandard `lessc` to the official one and enables CSS minification via the clean-css module. To build CSS, Node.js is required along with a `npm install` to get the tools installed locally in node_modules so there is no dependency on binaries in PATH. Benefits include: - Allows one to have a standard lessc in PATH. - Can now use command line switches on lessc. - Minified CSS brings faster page load times and also has the benefit of discouraging contributors from editing CSS directly. To build CSS, Node.js is required along with a `npm install` to get the tools installed locally based on the information in `package.json`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-02 12:08:34 -06:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#16350