[PR #2302] [MERGED] Trigger sync webhooks on UI commit #16334

Closed
opened 2025-11-02 12:08:06 -06:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/2302
Author: @ethantkoenig
Created: 8/13/2017
Status: Merged
Merged: 8/17/2017
Merged by: @lunny

Base: masterHead: fix/webhook


📝 Commits (2)

  • 2f368e1 Trigger sync webhooks on UI commit
  • 518de9d Also fix UI upload/delete

📊 Changes

3 files changed (+80 additions, -61 deletions)

View changed files

📝 models/repo_editor.go (+61 -46)
📝 models/update.go (+18 -1)
📝 routers/private/push_update.go (+1 -14)

📄 Description

Fixes #2295.

Ensure that AddTestPullRequestTask(..) called during a UI commit. For normally-pushed commits, AddTestPullRequestTask(..) is called by the post-receive webhook, but the webhook does not run* for UI commits.

(*It technically runs, but immediately quits because $SSH_ORIGINAL_COMMAND is not set)


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/2302 **Author:** [@ethantkoenig](https://github.com/ethantkoenig) **Created:** 8/13/2017 **Status:** ✅ Merged **Merged:** 8/17/2017 **Merged by:** [@lunny](https://github.com/lunny) **Base:** `master` ← **Head:** `fix/webhook` --- ### 📝 Commits (2) - [`2f368e1`](https://github.com/go-gitea/gitea/commit/2f368e1cc0b6fd4cbbdbec009f89fdad6a2923c1) Trigger sync webhooks on UI commit - [`518de9d`](https://github.com/go-gitea/gitea/commit/518de9d7e06a8773bb89ba858bdbb1e4b9a008fa) Also fix UI upload/delete ### 📊 Changes **3 files changed** (+80 additions, -61 deletions) <details> <summary>View changed files</summary> 📝 `models/repo_editor.go` (+61 -46) 📝 `models/update.go` (+18 -1) 📝 `routers/private/push_update.go` (+1 -14) </details> ### 📄 Description Fixes #2295. Ensure that `AddTestPullRequestTask(..)` called during a UI commit. For normally-pushed commits, `AddTestPullRequestTask(..)` is called by the `post-receive` webhook, but the webhook does not run* for UI commits. (*It technically runs, but immediately quits because `$SSH_ORIGINAL_COMMAND` is not set) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-02 12:08:06 -06:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#16334