[PR #2253] [MERGED] Convert xorm literal queries to method calls #16308

Closed
opened 2025-11-02 12:07:18 -06:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/2253
Author: @dubeg
Created: 8/3/2017
Status: Merged
Merged: 8/4/2017
Merged by: @lunny

Base: masterHead: convertLiteralQueries


📝 Commits (1)

  • dcfb485 Convert xorm literal queries to method calls

📊 Changes

2 files changed (+2 additions, -4 deletions)

View changed files

📝 models/migrations/migrations.go (+1 -2)
📝 models/migrations/v28.go (+1 -2)

📄 Description

The literal queries contained the keyword LIMIT, which doesn't exist in MSSQL. When I tried migrating, the process failed upon their execution. This change fixed it.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/2253 **Author:** [@dubeg](https://github.com/dubeg) **Created:** 8/3/2017 **Status:** ✅ Merged **Merged:** 8/4/2017 **Merged by:** [@lunny](https://github.com/lunny) **Base:** `master` ← **Head:** `convertLiteralQueries` --- ### 📝 Commits (1) - [`dcfb485`](https://github.com/go-gitea/gitea/commit/dcfb4858060d993ca519b58d2667a881f7bc5b7b) Convert xorm literal queries to method calls ### 📊 Changes **2 files changed** (+2 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `models/migrations/migrations.go` (+1 -2) 📝 `models/migrations/v28.go` (+1 -2) </details> ### 📄 Description The literal queries contained the keyword `LIMIT`, which doesn't exist in MSSQL. When I tried migrating, the process failed upon their execution. This change fixed it. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-02 12:07:18 -06:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#16308