github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-07-10 16:44:50 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

[PR #2204] [MERGED] Fix issue updated_unix bug #16286

New Issue
Closed
opened 2025-11-02 12:06:45 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-02 12:06:45 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/2204
Author: @ethantkoenig
Created: 7/23/2017
Status: ✅ Merged
Merged: 7/27/2017
Merged by: @lunny

Base: master ← Head: fix/issue_updated_unix

📝 Commits (1)

  • 3c0f6d8 Fix issue updated_unix bug

📊 Changes

5 files changed (+73 additions, -0 deletions)

View changed files

📝 models/issue.go (+1 -0)
📝 models/issue_comment.go (+4 -0)
➕ models/issue_comment_test.go (+41 -0)
📝 models/issue_test.go (+21 -0)
📝 models/unit_tests.go (+6 -0)

📄 Description

Fixes #1938.

The Issue.UpdatedUnix column is set in the BeforeUpdate() method. However, that write had no effect on the updated_unix column when updateIssueCols(..) was called, unless "updated_unix" was explicitly listed as a column to update.

This PR:

  • fixes updateIssueCols(..) to always update updated_unix.
  • updates createComment() to update an issue's updated_unix column when a comment is added.
  • includes relevant unit tests

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/2204 **Author:** [@ethantkoenig](https://github.com/ethantkoenig) **Created:** 7/23/2017 **Status:** ✅ Merged **Merged:** 7/27/2017 **Merged by:** [@lunny](https://github.com/lunny) **Base:** `master` ← **Head:** `fix/issue_updated_unix` --- ### 📝 Commits (1) - [`3c0f6d8`](https://github.com/go-gitea/gitea/commit/3c0f6d8bce576541c05b7b154b934a284f8c243a) Fix issue updated_unix bug ### 📊 Changes **5 files changed** (+73 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `models/issue.go` (+1 -0) 📝 `models/issue_comment.go` (+4 -0) ➕ `models/issue_comment_test.go` (+41 -0) 📝 `models/issue_test.go` (+21 -0) 📝 `models/unit_tests.go` (+6 -0) </details> ### 📄 Description Fixes #1938. The `Issue.UpdatedUnix` column is set in the `BeforeUpdate()` method. However, that write had no effect on the `updated_unix` column when `updateIssueCols(..)` was called, unless `"updated_unix"` was explicitly listed as a column to update. This PR: - fixes `updateIssueCols(..)` to always update `updated_unix`. - updates `createComment()` to update an issue's `updated_unix` column when a comment is added. - includes relevant unit tests --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-02 12:06:45 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#16286
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?