[PR #2161] [MERGED] Remove unit types commits and settings #16266

New Issue

GiteaMirror · 2025-11-02T12:06:18-06:00

GiteaMirror commented

2025-11-02 12:06:18 -06:00

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/2161
Author: @lafriks
Created: 7/13/2017
Status: ✅ Merged
Merged: 7/17/2017
Merged by: @lunny

Base: master ← Head: refactor_repo_tabs

📝 Commits (4)

275ca0b Remove unit types commits and settings
4f9d80a Can not limit units in administrator teams
90c0a0b Limit changing units only to teams with read and write access mode
33a01e5 Small code optimization

📊 Changes

20 files changed (+174 additions, -104 deletions)

View changed files

📝 integrations/repo_test.go (+1 -1)
📝 models/access_test.go (+2 -2)
📝 models/fixtures/access.yml (+6 -0)
📝 models/fixtures/repo_unit.yml (+12 -12)
📝 models/fixtures/team.yml (+4 -4)
📝 models/migrations/migrations.go (+2 -0)
📝 models/migrations/v16.go (+16 -16)
➕ models/migrations/v38.go (+56 -0)
📝 models/repo.go (+4 -0)
📝 models/repo_unit.go (+2 -7)
📝 models/unit.go (+10 -36)
📝 modules/context/repo.go (+3 -2)
📝 options/locale/locale_en-US.ini (+1 -0)
📝 public/css/index.css (+3 -0)
📝 public/js/index.js (+13 -0)
📝 public/less/_repository.less (+6 -0)
📝 routers/org/teams.go (+28 -19)
📝 routers/routes/routes.go (+2 -2)
📝 templates/org/team/new.tmpl (+2 -2)
📝 templates/repo/header.tmpl (+1 -1)

📄 Description

Remove unit type commits & settings as they were not working correctly anyway
Fix unit type checking as all unit types was always already set before loading user allowed unit types
Fix style so that when "Settings" tab is not visible would still be aligned more to left not in all width with lot of space in between tabs.
Fix RepoView3 test (user3 is organization and can not be used to log in)
Fix invalid unit test (user4 is in team1 so it must have access to repo3, changed test to user5)
Allow changing units only for teams with read or write access mode

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/2161 **Author:** [@lafriks](https://github.com/lafriks) **Created:** 7/13/2017 **Status:** ✅ Merged **Merged:** 7/17/2017 **Merged by:** [@lunny](https://github.com/lunny) **Base:** `master` ← **Head:** `refactor_repo_tabs` --- ### 📝 Commits (4) - [`275ca0b`](https://github.com/go-gitea/gitea/commit/275ca0b8e9cec9cdaabcb636a9c0036bfa41ee8b) Remove unit types commits and settings - [`4f9d80a`](https://github.com/go-gitea/gitea/commit/4f9d80a6e5f5145fb696fa94b652baeee8497e7a) Can not limit units in administrator teams - [`90c0a0b`](https://github.com/go-gitea/gitea/commit/90c0a0b4ae5048a329c3da5a4c0440c7135b80a8) Limit changing units only to teams with read and write access mode - [`33a01e5`](https://github.com/go-gitea/gitea/commit/33a01e5f1b9a1bedc9c69ec7550d6810c3d6e703) Small code optimization ### 📊 Changes **20 files changed** (+174 additions, -104 deletions) <details> <summary>View changed files</summary> 📝 `integrations/repo_test.go` (+1 -1) 📝 `models/access_test.go` (+2 -2) 📝 `models/fixtures/access.yml` (+6 -0) 📝 `models/fixtures/repo_unit.yml` (+12 -12) 📝 `models/fixtures/team.yml` (+4 -4) 📝 `models/migrations/migrations.go` (+2 -0) 📝 `models/migrations/v16.go` (+16 -16) ➕ `models/migrations/v38.go` (+56 -0) 📝 `models/repo.go` (+4 -0) 📝 `models/repo_unit.go` (+2 -7) 📝 `models/unit.go` (+10 -36) 📝 `modules/context/repo.go` (+3 -2) 📝 `options/locale/locale_en-US.ini` (+1 -0) 📝 `public/css/index.css` (+3 -0) 📝 `public/js/index.js` (+13 -0) 📝 `public/less/_repository.less` (+6 -0) 📝 `routers/org/teams.go` (+28 -19) 📝 `routers/routes/routes.go` (+2 -2) 📝 `templates/org/team/new.tmpl` (+2 -2) 📝 `templates/repo/header.tmpl` (+1 -1) </details> ### 📄 Description * Remove unit type commits & settings as they were not working correctly anyway * Fix unit type checking as all unit types was always already set before loading user allowed unit types * Fix style so that when "Settings" tab is not visible would still be aligned more to left not in all width with lot of space in between tabs. * Fix RepoView3 test (user3 is organization and can not be used to log in) * Fix invalid unit test (user4 is in team1 so it must have access to repo3, changed test to user5) * Allow changing units only for teams with read or write access mode --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-02 12:06:18 -06:00

GiteaMirror closed this issue

2025-11-02 12:06:18 -06:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#16266