github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-10 13:56:06 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

[PR #2092] [MERGED] Fix SQL bug in models.PullRequests #16226

New Issue
Closed
opened 2025-11-02 12:05:21 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-02 12:05:21 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/2092
Author: @ethantkoenig
Created: 7/1/2017
Status: ✅ Merged
Merged: 7/1/2017
Merged by: @lafriks

Base: master ← Head: fix/pull_api

📝 Commits (1)

  • bc1aec9 Fix SQL bug in models.PullRequests

📊 Changes

2 files changed (+32 additions, -2 deletions)

View changed files

➕ integrations/api_pull_test.go (+31 -0)
📝 models/pull.go (+1 -2)

📄 Description

Fixes the GET /repos/:owner/:repo/pulls API endpoint, which previously gave a 500 on Postgres.

Postgres doesn't like ORDER BY clauses in SELECT COUNT(*) ... queries.

Also add an integration test.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/2092 **Author:** [@ethantkoenig](https://github.com/ethantkoenig) **Created:** 7/1/2017 **Status:** ✅ Merged **Merged:** 7/1/2017 **Merged by:** [@lafriks](https://github.com/lafriks) **Base:** `master` ← **Head:** `fix/pull_api` --- ### 📝 Commits (1) - [`bc1aec9`](https://github.com/go-gitea/gitea/commit/bc1aec9857d463df3ee62aa796eb1794b8191cec) Fix SQL bug in models.PullRequests ### 📊 Changes **2 files changed** (+32 additions, -2 deletions) <details> <summary>View changed files</summary> ➕ `integrations/api_pull_test.go` (+31 -0) 📝 `models/pull.go` (+1 -2) </details> ### 📄 Description Fixes the `GET /repos/:owner/:repo/pulls` API endpoint, which previously gave a 500 on Postgres. Postgres doesn't like `ORDER BY` clauses in `SELECT COUNT(*) ...` queries. Also add an integration test. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-02 12:05:21 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#16226
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?