[PR #2001] [MERGED] Don't show non-comments in comments API #16174

New Issue

GiteaMirror · 2025-11-02T12:03:59-06:00

GiteaMirror commented

2025-11-02 12:03:59 -06:00

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/2001
Author: @ethantkoenig
Created: 6/18/2017
Status: ✅ Merged
Merged: 6/18/2017
Merged by: @lunny

Base: master ← Head: fix/comment_api

📝 Commits (1)

08583a3 Don't show non-comments in comments API

📊 Changes

5 files changed (+49 additions, -10 deletions)

View changed files

➕ integrations/api_comment_test.go (+39 -0)
📝 integrations/api_team_test.go (+1 -4)
📝 integrations/integration_test.go (+5 -0)
📝 integrations/version_test.go (+2 -6)
📝 models/issue_comment.go (+2 -0)

📄 Description

Fix the GET /repos/:owner/:repo/issues/:index/comments and GET /repos/:owner/:repo/issues/comments API endpoints to only return actual comments, and not "non-comment" comments (e.g. addition/removal of label)

Also add integration test.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/2001 **Author:** [@ethantkoenig](https://github.com/ethantkoenig) **Created:** 6/18/2017 **Status:** ✅ Merged **Merged:** 6/18/2017 **Merged by:** [@lunny](https://github.com/lunny) **Base:** `master` ← **Head:** `fix/comment_api` --- ### 📝 Commits (1) - [`08583a3`](https://github.com/go-gitea/gitea/commit/08583a316d58ddbe045f2705cd356184a63a762a) Don't show non-comments in comments API ### 📊 Changes **5 files changed** (+49 additions, -10 deletions) <details> <summary>View changed files</summary> ➕ `integrations/api_comment_test.go` (+39 -0) 📝 `integrations/api_team_test.go` (+1 -4) 📝 `integrations/integration_test.go` (+5 -0) 📝 `integrations/version_test.go` (+2 -6) 📝 `models/issue_comment.go` (+2 -0) </details> ### 📄 Description Fix the `GET /repos/:owner/:repo/issues/:index/comments` and `GET /repos/:owner/:repo/issues/comments` API endpoints to only return actual comments, and not "non-comment" comments (e.g. addition/removal of label) Also add integration test. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-02 12:03:59 -06:00

GiteaMirror closed this issue

2025-11-02 12:03:59 -06:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#16174