[PR #1935] [CLOSED] Fix parsing of received environment variables from SSH clients #16132

New Issue

GiteaMirror · 2025-11-02T12:03:01-06:00

GiteaMirror commented

2025-11-02 12:03:01 -06:00

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/1935
Author: @cybe
Created: 6/11/2017
Status: ❌ Closed

Base: master ← Head: ssh_parse_env

📝 Commits (1)

d7ca1f5 Fix parsing of environment variables.

📊 Changes

1 file changed (+12 additions, -8 deletions)

View changed files

📝 modules/ssh/ssh.go (+12 -8)

📄 Description

The inbuilt SSH server supports setting environment variable received from SSH clients. However, parsing of those variables was completely broken and ignored the actual SSH protocol wire format, thus was only successful by chance.

This new implementation uses standard operations from the crypto/ssh module to parse the SSH wire format.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/1935 **Author:** [@cybe](https://github.com/cybe) **Created:** 6/11/2017 **Status:** ❌ Closed **Base:** `master` ← **Head:** `ssh_parse_env` --- ### 📝 Commits (1) - [`d7ca1f5`](https://github.com/go-gitea/gitea/commit/d7ca1f5bfd6114c87cad3297b10e0578387c026b) Fix parsing of environment variables. ### 📊 Changes **1 file changed** (+12 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `modules/ssh/ssh.go` (+12 -8) </details> ### 📄 Description The inbuilt SSH server supports setting environment variable received from SSH clients. However, parsing of those variables was completely broken and ignored the actual SSH protocol wire format, thus was only successful by chance. This new implementation uses standard operations from the crypto/ssh module to parse the SSH wire format. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-02 12:03:01 -06:00

GiteaMirror closed this issue

2025-11-02 12:03:02 -06:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#16132