[PR #1855] [MERGED] Delete Public SSH Key tmp file after calculating fingerprint #16087

New Issue

GiteaMirror · 2025-11-02T12:01:59-06:00

GiteaMirror commented

2025-11-02 12:01:59 -06:00

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/1855
Author: @dnmgns
Created: 6/2/2017
Status: ✅ Merged
Merged: 6/8/2017
Merged by: @lunny

Base: master ← Head: cleanup_pubkey_tmp

📝 Commits (5)

2a1b51e Delete public key tmp file after calculating fingerprint
0d0f6e4 Move line
0cecf3e Remove defer statement
f84bc06 Readd defer statement and move remove
b03b204 Delete space

📊 Changes

1 file changed (+1 additions, -0 deletions)

View changed files

📝 models/ssh_key.go (+1 -0)

📄 Description

When using LDAP User Synchronization (#1478) with LDAP Public SSH Keys synchronization (#1844), the public key fingerprint calculation might be running with a quite high frequency.

As the tmp-files for calculating public key fingerprint is not deleted, the system could end up with lots of public tmp files causing inode issue and running out of disk space.

This PR addresses this issue by cleaning up the tmp file after the fingerprint has been calculated.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/1855 **Author:** [@dnmgns](https://github.com/dnmgns) **Created:** 6/2/2017 **Status:** ✅ Merged **Merged:** 6/8/2017 **Merged by:** [@lunny](https://github.com/lunny) **Base:** `master` ← **Head:** `cleanup_pubkey_tmp` --- ### 📝 Commits (5) - [`2a1b51e`](https://github.com/go-gitea/gitea/commit/2a1b51e39c5aa4b9e5ea925881d01af766f73fcc) Delete public key tmp file after calculating fingerprint - [`0d0f6e4`](https://github.com/go-gitea/gitea/commit/0d0f6e4673adb37b97acc7e288d658504f86de77) Move line - [`0cecf3e`](https://github.com/go-gitea/gitea/commit/0cecf3ed2991333483ca55d2e772be7e4f2ffd3c) Remove defer statement - [`f84bc06`](https://github.com/go-gitea/gitea/commit/f84bc0637c0bd3e1c5e3f8f1b44b516dd1442811) Readd defer statement and move remove - [`b03b204`](https://github.com/go-gitea/gitea/commit/b03b20446de3461257c0e5835419a6b7618307c9) Delete space ### 📊 Changes **1 file changed** (+1 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `models/ssh_key.go` (+1 -0) </details> ### 📄 Description When using LDAP User Synchronization (#1478) with LDAP Public SSH Keys synchronization (#1844), the public key fingerprint calculation might be running with a quite high frequency. As the tmp-files for calculating public key fingerprint is not deleted, the system could end up with lots of public tmp files causing inode issue and running out of disk space. This PR addresses this issue by cleaning up the tmp file after the fingerprint has been calculated. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-02 12:01:59 -06:00

GiteaMirror closed this issue

2025-11-02 12:02:00 -06:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#16087