github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-07-16 04:42:51 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

[PR #1843] [MERGED] Don't ignore error in getMergeCommit #16079

New Issue
Closed
opened 2025-11-02 12:01:49 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-02 12:01:49 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/1843
Author: @ethantkoenig
Created: 5/31/2017
Status: ✅ Merged
Merged: 6/1/2017
Merged by: @appleboy

Base: master ← Head: fix/pull_error

📝 Commits (1)

  • fda0f5f Don't ignore error in getMergeCommit

📊 Changes

1 file changed (+9 additions, -3 deletions)

View changed files

📝 models/pull.go (+9 -3)

📄 Description

Check for previously-ignored error in PullRequest.getMergeCommit(), and return appropriate errors in unexpected circumstances.

Should help in debugging #1186 (note: this PR does NOT fix the problem, but only helps to diagnose it)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/1843 **Author:** [@ethantkoenig](https://github.com/ethantkoenig) **Created:** 5/31/2017 **Status:** ✅ Merged **Merged:** 6/1/2017 **Merged by:** [@appleboy](https://github.com/appleboy) **Base:** `master` ← **Head:** `fix/pull_error` --- ### 📝 Commits (1) - [`fda0f5f`](https://github.com/go-gitea/gitea/commit/fda0f5f8e5d20dabe30676ed7b9932ec5e415349) Don't ignore error in getMergeCommit ### 📊 Changes **1 file changed** (+9 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `models/pull.go` (+9 -3) </details> ### 📄 Description Check for previously-ignored error in `PullRequest.getMergeCommit()`, and return appropriate errors in unexpected circumstances. Should help in debugging #1186 (note: this PR does __NOT__ fix the problem, but only helps to diagnose it) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-02 12:01:49 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#16079
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?